Allow the Read status bar command to copy its contents on the third keypress #7577
Conversation
|
@ehollig Whoa, are you coding now? Anyways, I would argue that this is
very much a user-facing feature addition and thus should be documented
in the What's New document.
…On 9/8/17, Ethan Holliger ***@***.***> wrote:
### Link to issue number:
Fixes #1785
### Summary of the issue:
When pressing the command say window title thrice, the text is copied to the
clipboard. This is currently not possible with the report status bar
command.
### Description of how this pull request fixes the issue:
This allows for the report status bar command to copy the information to the
clipboard, similar to say window title.
### Testing performed:
Opened notepad and performed the report status bar command thrice. Pasted
the contents of the status bar into the file.
### Known issues with pull request:
No information was spoken when performing the command three times in
Internet Explorer 11.
### Change log entry:
None needed.
You can view, comment on, or merge this pull request online at:
#7577
-- Commit Summary --
* Allow read status bar command to copy contents on third press to
clipboard
* Allow the Read status bar command copy its contents on third press
-- File Changes --
M source/globalCommands.py (9)
-- Patch Links --
https://github.com/nvaccess/nvda/pull/7577.patch
https://github.com/nvaccess/nvda/pull/7577.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#7577
--
Best Regards
Bhavya Shah
Blogger at Hiking Across Horizons: https://bhavyashah125.wordpress.com/
Contacting Me
E-mail Address: bhavya.shah125@gmail.com
Follow me on Twitter @BhavyaShah125 or www.twitter.com/BhavyaShah125
Mobile Number: +91 7506221750
|
|
Hi, as well as recorded in the user guide. CC @feerrenrut
|
| @@ -1,4 +1,4 @@ | |||
| # -*- coding: UTF-8 -*- | |||
| # -*- coding: UTF-8 -*- | |||
There was a problem hiding this comment.
Somehow, a weird character ended up at the start of this line. Could you have saved the file as UTF-8 with BOM? You might as well add your name to the copyright line in the process.
|
Congratulations with your first code contribution! |
|
Suggested whats new entry:
|
|
Oh, by the way, congrats on your first code contribution! |
|
Nice work. Just one thing I found, which are required. |
| speech.speakSpelling(text) | ||
| else: | ||
| if api.copyToClip(text): | ||
| ui.message(_("%s copied to clipboard")%text) |
There was a problem hiding this comment.
You need a translators comment above this line. Something like
#Translators: The message presented when the status bar is copied to the clipboard.
| @@ -1,4 +1,4 @@ | |||
| NVDA NVDA_VERSION User Guide | |||
| NVDA NVDA_VERSION User Guide | |||
There was a problem hiding this comment.
unintentional line change? maybe crlf?
|
rar, I'm dumb. |
feerrenrut
left a comment
There was a problem hiding this comment.
Looks good @ehollig, thanks for the contribution! Don't worry about it for this PR, we tend to update the en/changes.t2t file directly on master when we complete the merge. We do squash merges to master, and regular merges to next during incubation. This can cause merge conflicts in the changes file. That said, its really handy that the change log entry is provided on the PR (there is a section for it in the PR template). Thanks again!
|
@feerrenrut Ethan isn't in contributers.txt, FYR |
|
I noticed that the NVDA insert+1 help message for this command talks about copying the title (not status bar) to the clipboard on third press. |
|
Hi, yep, confirmed.
From: dan1982code [mailto:notifications@github.com]
Sent: Saturday, September 16, 2017 8:50 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] Allow the Read status bar command to copy its contents on the third keypress (#7577)
I noticed that the NVDA insert+1 help message for this command talks about copying the title (not status bar) to the clipboard on third press.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#7577 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkJxV9FHD_SXVftKSVMOfe-dMBBK4ks5si-4TgaJpZM4PQf0o> .
|
|
Thank you for pointing this out. It has been corrected. CC @@feerrenrut |
|
The grammar for the changes entry in the what's new is wrong. "it's" should be "its", and I belief it should be either "its content is", or "its contents are". I'm no expert though. |
|
Found another typo in the changes: "compaired with installs of previous NVDA versions." |
|
Hi, I’ll address documentation issues by end of this month once most of the features are introduced. Thanks.
From: dan1982code [mailto:notifications@github.com]
Sent: Tuesday, October 3, 2017 8:23 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] Allow the Read status bar command to copy its contents on the third keypress (#7577)
Found another typo in the changes: "compaired with installs of previous NVDA versions."
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#7577 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkI7CoPo94D_c_9_FLFzKD_v6SGjTks5solFhgaJpZM4PQf0o> .
|
Link to issue number:
Fixes #1785
Summary of the issue:
When pressing the command say window title thrice, the text is copied to the clipboard. This is currently not possible with the report status bar command.
Description of how this pull request fixes the issue:
This allows for the report status bar command to copy the information to the clipboard, similar to say window title.
Testing performed:
Opened notepad and performed the report status bar command thrice. Pasted the contents of the status bar into the file.
Known issues with pull request:
No information was spoken when performing the command three times in Internet Explorer 11.
Change log entry:
• changes:
• it is now possible to press the report status bar command three times to copy the status bar text to the clipboard.