From e5e1cc79957b1c2c3b4f529753f682cc69f5d4a0 Mon Sep 17 00:00:00 2001 From: ehollig <21368115+ehollig@users.noreply.github.com> Date: Wed, 6 Sep 2017 17:37:10 -0600 Subject: [PATCH 1/9] Allow read status bar command to copy contents on third press to clipboard --- source/globalCommands.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/source/globalCommands.py b/source/globalCommands.py index d7610224eaa..d3f080580b1 100755 --- a/source/globalCommands.py +++ b/source/globalCommands.py @@ -1,4 +1,4 @@ -# -*- coding: UTF-8 -*- +# -*- coding: UTF-8 -*- #globalCommands.py #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. @@ -1361,10 +1361,13 @@ def script_reportStatusLine(self,gesture): return if scriptHandler.getLastScriptRepeatCount()==0: ui.message(text) - else: + elif scriptHandler.getLastScriptRepeatCount()==1: speech.speakSpelling(text) + else: + if api.copyToClip(title): + ui.message(_("%s copied to clipboard")%text) # Translators: Input help mode message for report status line text command. - script_reportStatusLine.__doc__ = _("Reads the current application status bar and moves the navigator to it. If pressed twice, spells the information") + script_reportStatusLine.__doc__ = _("Reads the current application status bar and moves the navigator to it. If pressed twice, spells the information. If pressed three times, copies the title to the clipboard") script_reportStatusLine.category=SCRCAT_FOCUS def script_toggleMouseTracking(self,gesture): From 38b63f38d6582ddd8964af872bb7ca2852621107 Mon Sep 17 00:00:00 2001 From: ehollig <21368115+ehollig@users.noreply.github.com> Date: Thu, 7 Sep 2017 16:48:23 -0600 Subject: [PATCH 2/9] Allow the Read status bar command copy its contents on third press --- source/globalCommands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/globalCommands.py b/source/globalCommands.py index d3f080580b1..40b7242d064 100755 --- a/source/globalCommands.py +++ b/source/globalCommands.py @@ -1364,7 +1364,7 @@ def script_reportStatusLine(self,gesture): elif scriptHandler.getLastScriptRepeatCount()==1: speech.speakSpelling(text) else: - if api.copyToClip(title): + if api.copyToClip(text): ui.message(_("%s copied to clipboard")%text) # Translators: Input help mode message for report status line text command. script_reportStatusLine.__doc__ = _("Reads the current application status bar and moves the navigator to it. If pressed twice, spells the information. If pressed three times, copies the title to the clipboard") From 1771efcc5b59297b4aac2785cbec0d0971292a11 Mon Sep 17 00:00:00 2001 From: ehollig <21368115+ehollig@users.noreply.github.com> Date: Fri, 8 Sep 2017 08:31:47 -0600 Subject: [PATCH 3/9] Update user guide --- user_docs/en/userGuide.t2t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/user_docs/en/userGuide.t2t b/user_docs/en/userGuide.t2t index 45f06db4fd4..7ebbb3e07da 100644 --- a/user_docs/en/userGuide.t2t +++ b/user_docs/en/userGuide.t2t @@ -1,4 +1,4 @@ -NVDA NVDA_VERSION User Guide +NVDA NVDA_VERSION User Guide %!includeconf: ../userGuide.t2tconf @@ -278,7 +278,7 @@ There are some key commands that are useful when moving with the System focus: | Report current focus | NVDA+tab | NVDA+tab | announces the current object or control that has the System focus. Pressing twice will spell the information | | Report title | NVDA+t | NVDA+t | Reports the title of the currently active window. Pressing twice will spell the information. Pressing three times will copy it to the clipboard | | Read active window | NVDA+b | NVDA+b | reads all the controls in the currently active window (useful for dialogs) | -| Report Status Bar | NVDA+end | NVDA+shift+end | Reports the Status Bar if NVDA finds one. It also moves the navigator object to this location. Pressing twice will spell the information | +| Report Status Bar | NVDA+end | NVDA+shift+end | Reports the Status Bar if NVDA finds one. It also moves the navigator object to this location. Pressing twice will spell the information. Pressing three times will copy it to the clipboard | %kc:endInclude ++ Navigating with the System Caret ++[SystemCaret] From 62fed948b11d0a4d865210fd440e460dd3e2097a Mon Sep 17 00:00:00 2001 From: ehollig <21368115+ehollig@users.noreply.github.com> Date: Fri, 8 Sep 2017 08:50:04 -0600 Subject: [PATCH 4/9] Hopefully get rid of weird character, and added name to file --- source/globalCommands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/globalCommands.py b/source/globalCommands.py index 40b7242d064..93ae15800a8 100755 --- a/source/globalCommands.py +++ b/source/globalCommands.py @@ -3,7 +3,7 @@ #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. #See the file COPYING for more details. -#Copyright (C) 2006-2016 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Rui Batista, Joseph Lee, Leonard de Ruijter, Derek Riemer, Babbage B.V. +#Copyright (C) 2006-2016 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Rui Batista, Joseph Lee, Leonard de Ruijter, Derek Riemer, Babbage B.V., Ethan Holliger import time import itertools From cc034f04107f189fa44088ce186f148f1cdbd023 Mon Sep 17 00:00:00 2001 From: ehollig <21368115+ehollig@users.noreply.github.com> Date: Sun, 10 Sep 2017 15:04:13 -0600 Subject: [PATCH 5/9] Fixed encoding to UTF-8 and added change in what's new --- source/globalCommands.py | 2 +- user_docs/en/changes.t2t | 3 ++- user_docs/en/userGuide.t2t | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/source/globalCommands.py b/source/globalCommands.py index 93ae15800a8..59a6c5ca62f 100755 --- a/source/globalCommands.py +++ b/source/globalCommands.py @@ -1,4 +1,4 @@ -# -*- coding: UTF-8 -*- +# -*- coding: UTF-8 -*- #globalCommands.py #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t index 034e246841e..123e0b1124c 100644 --- a/user_docs/en/changes.t2t +++ b/user_docs/en/changes.t2t @@ -1,4 +1,4 @@ -What's New in NVDA +What's New in NVDA %!includeconf: ../changes.t2tconf @@ -18,6 +18,7 @@ - In browse mode, tabbing and moving with quick navigation commands no longer announces jumping out of containers such as lists and tables, which makes navigating more efficient. (#2591) - In Browse mode for Firefox and Chrome, the name of form field groups are now announced when moving into them with quick navigation or when tabbing. (#3321) - In browse mode, the quick navigation command for embedded objects (o and shift+o) now includes audio and video elements as well as elements with the aria roles application and dialog. (#7239) +- It is now possible to press the report status bar command three times to copy the status bar text to the clipboard. (#1785) == Bug Fixes == diff --git a/user_docs/en/userGuide.t2t b/user_docs/en/userGuide.t2t index 7ebbb3e07da..575dca742e0 100644 --- a/user_docs/en/userGuide.t2t +++ b/user_docs/en/userGuide.t2t @@ -1,4 +1,4 @@ -NVDA NVDA_VERSION User Guide +NVDA NVDA_VERSION User Guide %!includeconf: ../userGuide.t2tconf From 46265476ceb52c3e7d3740dcc8442a1bbd7168db Mon Sep 17 00:00:00 2001 From: ehollig <21368115+ehollig@users.noreply.github.com> Date: Sun, 10 Sep 2017 15:45:04 -0600 Subject: [PATCH 6/9] Added translater comment --- source/globalCommands.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source/globalCommands.py b/source/globalCommands.py index 59a6c5ca62f..3b277835447 100755 --- a/source/globalCommands.py +++ b/source/globalCommands.py @@ -1,4 +1,4 @@ -# -*- coding: UTF-8 -*- +# -*- coding: UTF-8 -*- #globalCommands.py #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. @@ -1365,6 +1365,7 @@ def script_reportStatusLine(self,gesture): speech.speakSpelling(text) else: if api.copyToClip(text): + # Translators: The message presented when the status bar is copied to the clipboard. ui.message(_("%s copied to clipboard")%text) # Translators: Input help mode message for report status line text command. script_reportStatusLine.__doc__ = _("Reads the current application status bar and moves the navigator to it. If pressed twice, spells the information. If pressed three times, copies the title to the clipboard") From fb0f66cb393d3634bbe69b65674cec61c2f5bd77 Mon Sep 17 00:00:00 2001 From: Reef Turner Date: Wed, 13 Sep 2017 10:44:59 +0800 Subject: [PATCH 7/9] Removed the BOM from globalCommands.py --- source/globalCommands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/globalCommands.py b/source/globalCommands.py index 3b277835447..b0eb8b63a20 100755 --- a/source/globalCommands.py +++ b/source/globalCommands.py @@ -1,4 +1,4 @@ -# -*- coding: UTF-8 -*- +# -*- coding: UTF-8 -*- #globalCommands.py #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. From 83e99138c28513403c594caf29d9a48d7ab823a2 Mon Sep 17 00:00:00 2001 From: ehollig <21368115+ehollig@users.noreply.github.com> Date: Sat, 16 Sep 2017 15:46:58 -0600 Subject: [PATCH 8/9] Corrected input help message --- source/globalCommands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/globalCommands.py b/source/globalCommands.py index b0eb8b63a20..2a05c0c4163 100755 --- a/source/globalCommands.py +++ b/source/globalCommands.py @@ -1368,7 +1368,7 @@ def script_reportStatusLine(self,gesture): # Translators: The message presented when the status bar is copied to the clipboard. ui.message(_("%s copied to clipboard")%text) # Translators: Input help mode message for report status line text command. - script_reportStatusLine.__doc__ = _("Reads the current application status bar and moves the navigator to it. If pressed twice, spells the information. If pressed three times, copies the title to the clipboard") + script_reportStatusLine.__doc__ = _("Reads the current application status bar and moves the navigator to it. If pressed twice, spells the information. If pressed three times, copies the status bar to the clipboard") script_reportStatusLine.category=SCRCAT_FOCUS def script_toggleMouseTracking(self,gesture): From 4a011af89d0f655860e21a19869b227aff61618f Mon Sep 17 00:00:00 2001 From: Reef Turner Date: Wed, 20 Sep 2017 11:23:52 +0800 Subject: [PATCH 9/9] Update contributors file --- contributors.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/contributors.txt b/contributors.txt index 0ea781a52f2..23e452f7a48 100644 --- a/contributors.txt +++ b/contributors.txt @@ -179,3 +179,4 @@ Florian Ionașcu Nicușor Untilă Julien Nabet Babbage B.V. +Ethan Holliger