Skip to content

#5050 add option for speech viewer on startup#6197

Merged
feerrenrut merged 6 commits into
masterfrom
i5050-AddOptionForSpeechViewerOnStartup
Aug 31, 2016
Merged

#5050 add option for speech viewer on startup#6197
feerrenrut merged 6 commits into
masterfrom
i5050-AddOptionForSpeechViewerOnStartup

Conversation

@feerrenrut

@feerrenrut feerrenrut commented Jul 21, 2016

Copy link
Copy Markdown
Contributor

Partially resolves #5050 (showing speech viewer at startup)

Added a config option to show the speechviewer on startup

This is a boolean field showSpeechViewerAtStartup in the general section of the configuration file.

Add GUI to toggle speech viewer opens on startup.

  • For exit crash fix see #5050 Fix race condition on exit of SpeechViewer #6201
  • Added a checkbox to the speechViewer (consistent with the
    welcomeDialog) to toggle launching on startup.
    • focus is set to the checkbox so that output to the speechViewer can
      start immediatly. The textCtrl was being considered to have focus
      even when another window was in focus.
  • Changed the speechViewer window to a dialog, in order to fix
    navigation issues:
    • Now able to alt + tab to the dialog in Windows 10.
    • Now able to tab to the checkbox

This is a boolean field `showSpeechViewerAtStartup` in the general section of the configuration file.
- Change in gui MainFrame Destroy. This avoids a race condition that
  causes an error on exit of NVDA.
  - The error raised: PyDeadObjectError: The C++ part of the
      SpeechViewerFrame object has been deleted, attribute access no
      longer allowed.
- Added a checkbox to the speechViewer (consistent with the
    welcomeDialog) to toggle launching on startup.
  - focus is set to the checkbox so that output to the speechViewer can
    start immediatly. The textCtrl was being considered to have focus
    even when another window was in focus.
- Changed the speechViewer window to a dialog, in order to fix
    navigation issues:
  - Now able to alt + tab to the dialog in Windows 10.
  - Now able to tab to the checkbox
Comment thread source/core.py
log.debug("Initializing GUI")
import gui
gui.initialize()

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only unix style line ending in the file. Replaced with a windows style line ending.

@feerrenrut

Copy link
Copy Markdown
Contributor Author

@michaelDCurran When you have a chance could you please take a look at this?

Comment thread source/config/__init__.py Outdated
#possible log levels are DEBUG, IO, DEBUGWARNING, INFO
loggingLevel = string(default="INFO")
showWelcomeDialogAtStartup = boolean(default=true)
showSpeechViewerAtStartup = boolean(default=false)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps move this option into a separate speechViewer section, as we are planning to also save position information as well.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about a sub-section under general?

On 7/21/2016 9:54 PM, Michael Curran wrote:

In source/config/init.py
#6197 (comment):

@@ -65,6 +65,7 @@ def validateConfig(configObj,validator,validationResult=None,keyList=None):
#possible log levels are DEBUG, IO, DEBUGWARNING, INFO
loggingLevel = string(default="INFO")
showWelcomeDialogAtStartup = boolean(default=true)

  • showSpeechViewerAtStartup = boolean(default=false)

Perhaps move this option into a separate speechViewer section, as we
are planning to also save position information as well.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nvaccess/nvda/pull/6197/files/0581ada05316383e7903e30dffc09f1256d9a3ce#r71823659,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFGivVg07p9-WQGZPgeeSQLugNHBj2EOks5qYD7ggaJpZM4JRhJV.


Derek Riemer
  • Department of computer science, third year undergraduate student.
  • Proud user of the NVDA screen reader.
  • Open source enthusiast.
  • Member of Bridge Cu
  • Avid skiier.

Websites:
Honors portfolio http://derekriemer.com
Awesome little hand built weather app!
http://django.derekriemer.com/weather/

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu
Phone: (303) 906-2194

Comment thread source/config/__init__.py Outdated
audioCoordinates_maxPitch = integer(default=880)
reportMouseShapeChanges = boolean(default=false)

[speechView]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename [speechView] to [speechViewer].

changed config section from "speechView" to "speechViewer"
@michaelDCurran

Copy link
Copy Markdown
Member

Looks fine to me.

feerrenrut added a commit that referenced this pull request Jul 29, 2016
Adds option to open speech viewer on startup. Re #5050

Merge branch 'i5050-AddOptionForSpeechViewerOnStartup' into next
…peechViewerOnStartup

Conflicts:
	source/speechViewer.py
@feerrenrut feerrenrut merged commit aa61f52 into master Aug 31, 2016
@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Aug 31, 2016
feerrenrut added a commit that referenced this pull request Aug 31, 2016
An option to open the speech viewer window on startup has been added. (#5050)
@feerrenrut feerrenrut deleted the i5050-AddOptionForSpeechViewerOnStartup branch January 17, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to show Speech Viewer by default (and save dimensions and position of the window)

4 participants