#5050 Fix race condition on exit of SpeechViewer#6201
Merged
Conversation
When exiting nvda with the speechViewer window open, sometimes destroy is called before the queueHandler has finished speaking all text (and then calling the speechViewer). This update stops the speechViewer from being accessed after the window is destroyed.
Contributor
Author
|
@michaelDCurran Please take a look at this when you get the chance |
Member
|
This looks fine to me. |
feerrenrut
added a commit
that referenced
this pull request
Jul 29, 2016
feerrenrut
added a commit
that referenced
this pull request
Aug 31, 2016
Fixed a rare issue when exiting NVDA while the speech viewer is open causing an error. (#5050)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exiting nvda with the speechViewer window open, sometimes destroy is called before the queueHandler has finished speaking all text (and then calling the speechViewer). This update stops the speechViewer from being accessed after the window is destroyed.
The error raised: PyDeadObjectError: The C++ part of the SpeechViewerFrame object has been deleted, attribute access no longer allowed.