Revert "Correctly version and sign the 32 bit synthDriverHost runtime executable and don't include unnecessary pdb lib and exp files"#19714
Merged
Conversation
… executa…" This reverts commit 5e20004.
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts prior changes related to versioning/signing and packaging of the 32-bit synthDriverHost runtime, to address hangs in signed builds where NVDA fails to start after installation.
Changes:
- Stop signing the
nvda_synthDriverHost.exeruntime executable during distribution generation. - Remove
--version/--publisheroverrides from the synthDriverHost32 runtime builder and associated CI invocation. - Adjust packaging of
_synthDrivers32data files to use recursive collection again.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
source/setup.py |
Switch _synthDrivers32 packaging back to recursive data file collection when the runtime directory exists. |
sconstruct |
Remove runtime exe from signing list; simplify synthDriverHost32 runtime build command. |
runtime-builders/synthDriverHost32/setup-runtime.py |
Remove CLI overrides for version/publisher and rely on NVDA’s buildVersion. |
.github/workflows/testAndPublish.yml |
Update runtime-builder invocation to match removed CLI args. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SaschaCowley
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts PR
Reverts #19683
Issues fixed
N/A
Issues reopened
Reopens #19654
Reopens #19653
Reason for revert
This PR is causing system tests to hang indefinitely for signed builds. NVDA fails to start after being installed.
Compare these two commit builds
Can this PR be reimplemented? If so, what is required for the next attempt
Create
try-builds from the PR which pass