Skip to content

Beta to master#19704

Merged
seanbudd merged 8 commits into
masterfrom
beta
Feb 27, 2026
Merged

Beta to master#19704
seanbudd merged 8 commits into
masterfrom
beta

Conversation

@seanbudd

Copy link
Copy Markdown
Member

No description provided.

RyanMcCleary and others added 2 commits February 26, 2026 18:28
)

Closes #19670
Summary of the issue:

A bug in Microsoft Word is causing math objects to be spoken inconsistently, sometimes using MathCAT and at other times using Word's native math speech.
Description of user facing changes:

An option is added to the math settings panel to use native math speech while in Word. When checked, MathCAT is disabled while in Word and re-enabled when another application gains focus.
Description of developer facing changes:

N/A
Description of development approach:

    Handlers were added in winword.py for the gainFocus, loseFocus, and terminate events that disable and re-enable MathCAT.
    Two new functions were added to mathPres/__init__.py: disable and enable, which save and restore the three global provider objects.
Copilot AI review requested due to automatic review settings February 26, 2026 07:35
@seanbudd seanbudd requested review from a team as code owners February 26, 2026 07:35
@seanbudd seanbudd requested review from Qchristensen and SaschaCowley and removed request for Qchristensen, SaschaCowley and Copilot February 26, 2026 07:35
@seanbudd seanbudd enabled auto-merge February 26, 2026 07:36
Summary of the issue:

As of today, system tests are now regularly running longer than 10min.

Todays actions release may be related
Description of user facing changes:

None
Description of developer facing changes:

fix up time out for system tests
Copilot AI review requested due to automatic review settings February 26, 2026 08:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Math settings option to prefer Microsoft Word’s native equation presentation over MathCAT when working in Word, and updates docs/CI accordingly.

Changes:

  • Add a “Use native math speech in Word and Outlook” checkbox to Math settings, persisted in config.
  • Add mathPres.terminate() and use it from the Word app module on focus gain when the option is enabled.
  • Increase GitHub Actions system test job timeout from 10 to 15 minutes.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
user_docs/en/userGuide.md Documents the new Math option and adds a help anchor.
source/mathPres/init.py Adds a new terminate() helper that clears registered providers.
source/gui/settingsDialogs.py Adds the new checkbox to the Math settings panel and saves it to config.
source/config/configSpec.py Defines the new math.other.useWordNativeMath config setting.
source/appModules/winword.py Disables math presentation providers while Word has focus when enabled.
.github/workflows/testAndPublish.yml Extends system test timeout to reduce CI flakiness.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/config/configSpec.py
Comment thread source/mathPres/__init__.py
Comment thread source/appModules/winword.py
Comment thread source/gui/settingsDialogs.py
Comment thread user_docs/en/userGuide.md
andy72039 and others added 3 commits February 27, 2026 10:20
… executable and don't include unnecessary pdb lib and exp files" (#19714)

### Reverts PR
Reverts #19683

### Issues fixed
N/A

### Issues reopened
<!-- Issues that will be re-opened by reverting, i.e. the issues that
were fixed via the PR getting reverted -->
Reopens #19654
Reopens #19653

### Reason for revert
This PR is causing system tests to hang indefinitely for signed builds.
NVDA fails to start after being installed.

Compare these two commit builds

- https://github.com/nvaccess/nvda/actions/runs/22465329705
- https://github.com/nvaccess/nvda/actions/runs/22465348278

### Can this PR be reimplemented? If so, what is required for the next
attempt
Create `try-` builds from the PR which pass
)

### Reverts PR
Reverts #19703

### Issues fixed
None

### Issues reopened
None

### Reason for revert

PR was unnecessary.
See #19714 for more information

### Can this PR be reimplemented? If so, what is required for the next
attempt
SaschaCowley and others added 2 commits February 27, 2026 15:13
Summary of the issue:

Python does not like it when you have multiple patch versions on the same system. This was making it difficult to work on alpha and beta versions of NVDA at the same time.
Description of user facing changes:

None.
Description of developer facing changes:

Betas are now built with Python 3.13.12. Practically this should make no difference.
Description of development approach:

Cherry-picked d0be47c to beta and updated the change log.
@github-actions github-actions Bot requested a deployment to snapshot February 27, 2026 05:30 Abandoned
@seanbudd seanbudd disabled auto-merge February 27, 2026 05:36
@seanbudd seanbudd merged commit a94c7f8 into master Feb 27, 2026
114 of 116 checks passed
@github-actions github-actions Bot added this to the 2026.2 milestone Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants