Set the MathCAT output code automatically by NVDA language#19368
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the issue where "Nemeth" was an unsuitable default MathCAT Braille code for NVDA's global user base. It introduces an "Automatic" Braille code option that selects an appropriate code based on the current NVDA language, with ASCIIMath as the fallback.
Key changes:
- Adds automatic Braille code selection based on NVDA language (Spanish→CMU, Swedish→Swedish, Vietnamese→Vietnam, default→ASCIIMath)
- Changes the default MathCAT Braille code from "Nemeth" to "Auto"
- Updates the Math settings GUI to display the automatic option with the effective code shown in parentheses
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| source/buildVersion.py | Bumps version from 2026.1 to 2026.2 |
| user_docs/en/changes.md | Adds placeholder sections for the 2026.2 release |
| source/config/configSpec.py | Changes the default brailleCode from "Nemeth" to "Auto" |
| source/mathPres/MathCAT/preferences.py | Implements getAutoBrailleCode() for language-based code selection and setEffectiveBrailleCode() to apply the effective code at runtime |
| source/mathPres/MathCAT/MathCAT.py | Calls setEffectiveBrailleCode() during initialization to apply the effective Braille code |
| source/gui/settingsDialogs.py | Updates the Math settings panel to show "Automatic" as the first option with the current effective code displayed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
CC @RyanMcCleary. |
seanbudd
reviewed
Dec 11, 2025
seanbudd
left a comment
Member
There was a problem hiding this comment.
Thanks @codeofdusk - generally looks good to me
seanbudd
reviewed
Dec 11, 2025
seanbudd
reviewed
Dec 11, 2025
seanbudd
approved these changes
Dec 11, 2025
Member
|
Thanks @codeofdusk |
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Dec 11, 2025
Follow-up of #19368. Summary of the issue: Portuguese usually uses the código matemático unificado (per the ONCE): ...la actualización del código matemático unificado, realizada por la Comisión Técnica de Ciencias del Consejo Iberoamericano del Braille. Description of how this pull request fixes the issue: Mapped pt_BR and pt_PT to CMU in the MathCAT auto table. Testing strategy: Verified mapping.
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Dec 15, 2025
Split from #19227. Follow-up of #19368. Summary of the issue: The automatic Braille entry for Finnish was incorrect. Several languages could have more reasonable Braille defaults. Description of how this pull request fixes the issue: Simplify (key on base language only, not region codes), fix "fi", and expand Braille auto language table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #19233.
Summary of the issue:
nemethis unsuitable as a default MathCAT output code for NVDA's global user base (see #19233 for details).Description of how this pull request fixes the issue:
Adds a new "automatic" Braille code config option and switched to it by default. This option:
ASCIIMath.Testing strategy:
Changed NVDA language to Spanish and verified that CMU became the effective code when the Braille code option was set to
auto.Known issues with pull request:
None known
Code Review Checklist: