Improve language handling for MathCAT braille#19375
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes the automatic Braille entry for Finnish and simplifies the MathCAT Braille language mapping by focusing on base language codes rather than region-specific codes. It also expands the Braille auto language table with additional language mappings.
- Corrected the Finnish Braille code from "ASCIIMath-finnish" to "ASCIIMath-fi"
- Simplified language mapping to use base language codes only (e.g., "pt" instead of "pt_BR", "pt_PT")
- Expanded the language-to-Braille code mapping table with 11 additional languages
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Split from #19227. Follow-up of #19368.
Summary of the issue:
Description of how this pull request fixes the issue:
Simplify (key on base language only, not region codes), fix "fi", and expand Braille auto language table.
Testing strategy:
Braille mapping still functional.
Known issues with pull request:
None known
Code Review Checklist: