Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes incorrect OS architecture detection in NVDA's update check mechanism by correcting the use of the wrong Windows environment variable.
- Replaces incorrect
PROCESSOR_ARCHITEW6432with correctPROCESSOR_ARCHITECTUREenvironment variable - Updates both the update check logic and corresponding unit test
- Resolves issue where NVDA incorrectly identified 64-bit systems as 32-bit, causing wrong version returns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/updateCheck.py | Corrects environment variable usage for OS architecture detection in update check |
| tests/unit/test_winVersion.py | Updates unit test to use correct environment variable for consistency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
seanbudd
commented
Oct 3, 2025
SaschaCowley
requested changes
Oct 3, 2025
seanbudd
commented
Oct 3, 2025
seanbudd
commented
Oct 3, 2025
SaschaCowley
approved these changes
Oct 3, 2025
SaschaCowley
pushed a commit
that referenced
this pull request
Oct 9, 2025
Fixup of #19020 ### Summary of the issue: Since migrating alphas to 64bit, the NV Access server has been updated to refer 32bit OSs to 2025.3 rather than the latest NVDA version. However, this was implemented incorrectly, checking the `x64` parameter rather than `osArchitecture`. Historically the `x64` parameter is used to determine if the OS is AMD64, not if the OS supports 64-bit software, which includes ARM based OSs. #19020 changed updateCheck to always send True for 64-bit OSs, whereas it should continue to only send the flag if AMD64 and instead the server should be fixed ### Description of user facing changes: None (with server side changes implemented) ### Description of developer facing changes: None ### Description of development approach: Restore update check behaviour to before 64-bit alphas ### Testing strategy: Test on prod ### Known issues with pull request: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18983
Summary of the issue:
NVDA incorrectly identified the OS architecture as 32bit when running as a 64bit process.
This caused the update check to return 2025.3 as the expected NVDA version, as NVDA falsely said the system was 32bit.
Description of user facing changes:
Update check works for alphas
Description of developer facing changes:
None
Description of development approach:
Fix PROCESSOR_ARCHITEW6432 usages
Testing strategy:
test update check on alphas
Known issues with pull request:
Code Review Checklist: