Only flag x64 if AMD64#19052
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the update check behavior to correctly identify AMD64 architecture. It restores the x64 parameter to only be True when the OS architecture is specifically AMD64, reverting a change that incorrectly set it to always True for 64-bit systems.
- Reverts the
x64parameter from always beingTrueto onlyTruefor AMD64 architecture - Maintains the
osArchitectureparameter to provide the actual processor architecture - Aligns with server-side logic that expects
x64to indicate AMD64 specifically, not just 64-bit capability
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SaschaCowley
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixup of #19020
Summary of the issue:
Since migrating alphas to 64bit, the NV Access server has been updated to refer 32bit OSs to 2025.3 rather than the latest NVDA version.
However, this was implemented incorrectly, checking the
x64parameter rather thanosArchitecture.Historically the
x64parameter is used to determine if the OS is AMD64, not if the OS supports 64-bit software, which includes ARM based OSs.#19020 changed updateCheck to always send True for 64-bit OSs, whereas it should continue to only send the flag if AMD64 and instead the server should be fixed
Description of user facing changes:
None (with server side changes implemented)
Description of developer facing changes:
None
Description of development approach:
Restore update check behaviour to before 64-bit alphas
Testing strategy:
Test on prod
Known issues with pull request:
Code Review Checklist: