Skip to content

Update liblouis to 3.35.0#18848

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:louis335
Sep 5, 2025
Merged

Update liblouis to 3.35.0#18848
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:louis335

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

None

Summary of the issue:

A new version of liblouis has been released.

Description of user facing changes:

Table updates, see liblouis changelog.

Description of developer facing changes:

None

Description of development approach:

Updated submodule

Testing strategy:

Unit tests
test from source

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@LeonarddeR LeonarddeR marked this pull request as ready for review September 1, 2025 18:54
Copilot AI review requested due to automatic review settings September 1, 2025 18:54
@LeonarddeR LeonarddeR requested a review from a team as a code owner September 1, 2025 18:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the liblouis Braille translator dependency from version 3.34.0 to 3.35.0, bringing improvements to various Braille translations including Portuguese 8-dot, Greek International, Biblical Hebrew, Norwegian 8-dot, and Unified English Braille.

  • Updated liblouis submodule to version 3.35.0
  • Updated documentation to reflect the new version
  • Added changelog entry describing the improvements

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
user_docs/en/changes.md Added changelog entry documenting the liblouis update and its improvements
projectDocs/dev/createDevEnvironment.md Updated version reference from 3.34.0 to 3.35.0
include/liblouis Updated submodule commit to point to liblouis 3.35.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codeofdusk

Copy link
Copy Markdown
Contributor

@LeonarddeR It looks like there are new tables. Do we need to register them in braille.py?

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Sep 1, 2025
@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

Ah, it was not mentioned in the news file, I'll add it later today.

@LeonarddeR LeonarddeR marked this pull request as draft September 2, 2025 07:18
@LeonarddeR LeonarddeR marked this pull request as ready for review September 2, 2025 19:47
@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

@nishimotz May I ask you to reflect on the added Japanese table? Is the current naming clear/distinct enough?

Comment thread user_docs/en/changes.md Outdated
@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

@seanbudd I think this is ready to go. For the new Japanese table, we're following naming as provided by liblouis.

@seanbudd seanbudd merged commit fea7c35 into nvaccess:master Sep 5, 2025
40 checks passed
@github-actions github-actions Bot added this to the 2026.1 milestone Sep 5, 2025
@LeonarddeR LeonarddeR mentioned this pull request Sep 25, 2025
4 tasks
seanbudd pushed a commit that referenced this pull request Sep 29, 2025
Fixup for #18848
Summary of the issue:

The v3.35.0 tag on liblouis git repository is some commits behind the actual 3.35 release. The tagged version we used before didn't have its version number changed, so NVDA reports it as 3.34.0
Description of user facing changes:

NOne
Description of developer facing changes:

None
@seanbudd seanbudd mentioned this pull request Oct 10, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants