Use later liblouis commit#18995
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the liblouis submodule to use a more recent commit from September 1st to fix version reporting issues. The v3.35.0 tag was outdated and caused NVDA to incorrectly report the liblouis version as 3.34.0 instead of 3.35.0.
- Updates liblouis submodule commit hash to a more recent version
- Fixes version number reporting in NVDA logs
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
Thanks @LeonarddeR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixup for #18848
Summary of the issue:
The v3.35.0 tag on liblouis git repository is some commits behind the actual 3.35 release. The tagged version we used before didn't have its version number changed, so NVDA reports it as 3.34.0
Description of user facing changes:
NOne
Description of developer facing changes:
None
Description of development approach:
Update submodule to the most recent commit from september 1st.
Testing strategy:
Ensure that version is properly reported in log
Known issues with pull request:
None
Code Review Checklist:
x] Documentation: