Split Turkish braille tables#18726
Conversation
45f76d4 to
50fc739
Compare
|
Hi, I advise rethinking the PR strategy as braille table splits/merges are first done on Liblouis before brought into NVDA. Further, you need someone who reads and writes Turkish (and Turkish braille code) to test changes. Thanks. |
50fc739 to
45f76d4
Compare
|
These changes was already made in liblouis. The tables were mapped incorrectly in NVDA. I fixed this. |
|
Hi, and we can assume this is part of the latest stable version of Liblouis? If yes and if NV Access says yes, then I think it should become part of 2025.2 instead. Thanks.
|
|
The changes here are part of liblouis 3.34. But I don't know how to rebase this pull request to the beta branch. |
45f76d4 to
a91fea0
Compare
92f4c17 to
45f76d4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi - please ignore the previous comment, here's some simpler suggestions You'll need to use git rebase. Make sure to back up your branch to another branch or tag with the same commit before performing the rebase. Assuming your This may open up an interactive rebase editor if there are merge conflicts. Alternatively, you can perform a cherry-pick. git checkout beta
git checkout -b newBranchFromBeta
git cherry-pick <commit1FromOldBranch>Repeat cherry-pick for all the commits you wish to copy over. |
1e661e7 to
8e4d086
Compare
(cherry picked from commit 45f76d4)
8e4d086 to
60488ef
Compare
LeonarddeR
left a comment
There was a problem hiding this comment.
I think you can only mark one table as inputForLangs and outputForLangs per language.
This reverts commit 6ef33bd.
|
@SaschaCowley Why was this merged while my request for changes was still open? Did I miss something? if inputForLangs is not None:
for lang in inputForLangs:
if lang in _inputTableForLangs:
log.warning(
f"input table lang {lang} already set to {_inputTableForLangs[lang]} overwriting to {table.fileName}",
)
_inputTableForLangs[lang] = table.fileName
if outputForLangs is not None:
for lang in outputForLangs:
if lang in _outputTableForLangs:
log.warning(
f"output table lang {lang} already set to {_outputTableForLangs[lang]} overwriting to {table.fileName}",
)I think these should become errors or even exceptions to ensure this is not missed in the future. |
|
@LeonarddeR that was my mistake. Note the PR has now been reverted. |
Link to issue number:
None
Summary of the issue:
The Turkish braille tables is incorrect in NVDA.
Description of user facing changes:
The user will see the Turkish 8 dot computer braille, Turkish grade 1 and Turkish grade 2.
Description of developer facing changes:
None
Description of development approach:
Add original Turkish grade 1, and rename tr.ctb as Turkish 8 dot computer braille.
Testing strategy:
Manual test using a braille display.
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary