Revert "Split Turkish braille tables"#18754
Conversation
This reverts commit 6ef33bd.
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes that split Turkish braille tables into separate entries, consolidating them back to the original configuration. The revert removes the Turkish 8-dot computer braille table and the separate Turkish grade 1 table, while modifying the remaining Turkish grade 2 table to remove language-specific input/output configuration.
- Removes Turkish 8-dot computer braille table entry
- Removes separate Turkish grade 1 table entry
- Modifies Turkish grade 2 table to remove language associations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # Translators: The name of a braille table displayed in the | ||
| # braille settings dialog. | ||
| addTable("tr.ctb", _("Turkish 8 dot computer braille"), inputForLangs={"tr"}, outputForLangs={"tr"}) | ||
| addTable("tr.ctb", _("Turkish grade 1"), inputForLangs={"tr"}, outputForLangs={"tr"}) |
There was a problem hiding this comment.
The table name 'tr.ctb' suggests a generic Turkish table but the display name specifies 'grade 1'. This inconsistency between the filename and display name could be confusing. Consider using a more descriptive filename like 'tr-g1.ctb' or updating the display name to be more generic.
| addTable("tr.ctb", _("Turkish grade 1"), inputForLangs={"tr"}, outputForLangs={"tr"}) | |
| addTable("tr-g1.ctb", _("Turkish grade 1"), inputForLangs={"tr"}, outputForLangs={"tr"}) |
| # Translators: The name of a braille table displayed in the | ||
| # braille settings dialog. | ||
| addTable("tr-g2.ctb", _("Turkish grade 2"), contracted=True, inputForLangs={"tr"}, outputForLangs={"tr"}) | ||
| addTable("tr-g2.ctb", _("Turkish grade 2"), contracted=True) |
There was a problem hiding this comment.
Removing the inputForLangs and outputForLangs parameters from the Turkish grade 2 table breaks the language association that was present in the reverted code. This could impact automatic table selection for Turkish content. Consider whether this language association should be preserved.
| addTable("tr-g2.ctb", _("Turkish grade 2"), contracted=True) | |
| addTable("tr-g2.ctb", _("Turkish grade 2"), contracted=True, inputForLangs={"tr"}, outputForLangs={"tr"}) |
Reverts #18726