Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes failing tests by updating the license checking configuration to accommodate a licensing metadata issue with the Markdown package. The PR resolves a dependency lock mismatch that was causing pre-commit checks to fail after a previous update to python-markdown.
- Added Markdown package to the license check ignore list due to incorrect PyPI license metadata
- Addresses test failures caused by uv.lock environment mismatch from PR #18638
seanbudd
added a commit
that referenced
this pull request
Aug 8, 2025
Summary of the issue: As noted in #18645, if the uv-lock pre-commit step fails, running checkPo will also fail. When checkPo fails, it's unclear why, as the warning logs are not related. Description of user facing changes: None Description of developer facing changes: PR failures are slightly more obvious when changes to uv.lock have not been committed correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixup of #18638
#18638 introduced an update to python-markdown, which was not captured in uv.lock.
The uv environment mismatch caused pre-commit checks to fail, including the translation comment check separately.
The latest pypi entry doesn't seem to capture the license correctly, so our license check filtering needed to be updated too