Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where tabs were being replaced with spaces in code fences when converting markdown to HTML, which caused incorrect syntax in examples for character descriptions, gestures, and symbol files in the development guide.
- Added pymdown-extensions library with superfences extension to preserve tabs in code blocks
- Updated markdown processing to use ordered extensions instead of unordered sets
- Deprecated the DEFAULT_EXTENSIONS constant with backward compatibility
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/md2html.py | Updated markdown processing to preserve tabs, added deprecation handling for DEFAULT_EXTENSIONS, and configured pymdownx.superfences |
| pyproject.toml | Updated Markdown version and added pymdown-extensions dependency |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
seanbudd
commented
Aug 7, 2025
seanbudd
commented
Aug 7, 2025
Member
Author
|
Uh this had failing tests and might need to be reverted |
Merged
seanbudd
added a commit
that referenced
this pull request
Aug 8, 2025
Fixup of #18638 #18638 introduced an update to python-markdown, which was not captured in uv.lock. The uv environment mismatch caused pre-commit checks to fail, including the translation comment check separately. The latest pypi entry doesn't seem to capture the license correctly, so our license check filtering needed to be updated too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18622
Summary of the issue:
Tabs are replaced with spaces in codefences when converting markdown to html.
This causes examples for characterDescriptions, gestures and symbol files to contain incorrect syntax.
Description of user facing changes:
Fixed example in dev guide
Description of developer facing changes:
Description of development approach:
Testing strategy:
Built dev guide, ensured tabs are preserved
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary