Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the CI/CD build environment from Windows Server 2022 to Windows 2025 to align with the development environment and fix notepad focus issues that prevented symbol pronunciation tests from running.
- Migrates all GitHub workflow jobs from
windows-latesttowindows-2025 - Explicitly installs Python 3.11.9 in jobs where it's not pre-installed on Windows 2025
- Re-enables symbol pronunciation tests that were previously excluded due to Windows 10 notepad bugs
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/system/robot/symbolPronunciationTests.robot | Removes excluded_from_build tags to re-enable symbol pronunciation tests |
| tests/system/libraries/NotepadLib.py | Updates type annotations to modern union syntax and fixes navigation command |
| .github/workflows/testAndPublish.yml | Updates all jobs to windows-2025 and adds explicit Python installation steps |
| .github/workflows/regenerate_english_userDocs_translation_source.yml | Updates to windows-2025 and modernizes Python setup |
| .github/workflows/fetch-crowdin-translations.yml | Updates to windows-2025 and reorders Python setup |
| .github/workflows/codeql.yml | Updates to windows-2025 |
| .github/workflows/add-new-language.yml | Updates to windows-2025 and modernizes Python setup |
Comments suppressed due to low confidence (2)
.github/workflows/testAndPublish.yml:58
- Python version 3.11.9 may not exist. The latest Python 3.11.x series was 3.11.8 as of my last update. Consider using '3.11' to get the latest patch version or verify that 3.11.9 has been released.
python-version: '3.11.9'
tests/system/libraries/NotepadLib.py:14
- The import for
Optionalis being removed but the file is switching to union syntax. This is good practice, but ensure all usages of_Optionalthroughout the file have been updated to the new union syntax.
from SystemTestSpy import (
SaschaCowley
approved these changes
Jul 31, 2025
5 tasks
seanbudd
added a commit
that referenced
this pull request
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15104
Fixes #14372
Fixes #14353
Summary of the issue:
windows-latesttowindows-2025this year.Description of user facing changes:
None
Description of developer facing changes:
symbols tests are re-enabled
Description of development approach:
setup-pythonmore frequently as our required version of python doesn't come pre-installed in windows-2025. This can be fixed in Update to python 3.13 #18591symstore.exeis not installed at all or not installed in the expected place.Testing strategy:
CI/CD tests
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary