Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the Windows SDK version from 10.0 to 10.1 to address installation failures and use the latest available version for symbol creation during the build process.
- Updates chocolatey package installation command to use windows-sdk-10.1 instead of windows-sdk-10.0
- Aims to resolve occasional installation failures with the older version
- Maintains the same symstore.exe functionality for symbol creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixup from #18592
Summary of the issue:
We are installing an older version of Windows SDK for symstore.
We should use the latest version 10.1.
The installation of 10.0 seems to also fail occasionally #18597 (comment)
Description of user facing changes:
None
Description of developer facing changes:
None
Description of development approach:
None
Testing strategy:
Check if symbols are built from this PR
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary