Revert root certificate changes#18527
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts root certificate handling changes that were causing issues with NVDA remote functionality and breaking add-on APIs. The revert removes truststore integration and returns to the previous implementation of manual Windows root certificate updates.
- Removes truststore dependency and SSL context injection
- Reverts to manual certificate handling for update checks and add-on downloads
- Restores original SSL configuration for remote client connections
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| user_docs/en/changes.md | Removes changelog entries for the reverted certificate features |
| source/utils/networking.py | Completely removes the networking utility module |
| source/updateCheck.py | Restores manual certificate handling and moves structures back inline |
| source/core.py | Removes truststore SSL injection from main initialization |
| source/addonStore/network.py | Reverts certificate verification handling in add-on downloads |
| source/addonStore/dataManager.py | Reverts to direct requests calls instead of networking utilities |
| source/_remoteClient/transport.py | Restores original SSL context configuration |
| source/_remoteClient/server.py | Removes extra whitespace |
| pyproject.toml | Removes truststore dependency |
SaschaCowley
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts PR
Reverts #18354
Reverts #18490
Reverts #18402
Issues fixed
Fixes #18519
Issues reopened
Reopens #15905
Reason for revert
The current implementation breaks NVDA remote and breaks add-on APIs
Can this PR be reimplemented? If so, what is required for the next attempt
inject_into_ssl, extract_from_sslwhere required