NLS eReader Zoomax braille driver by florin-trutiu · Pull Request #18260 · nvaccess/nvda

florin-trutiu · 2025-06-16T09:25:50Z

Link to issue number:

Summary of the issue:

This is the NVDA driver for the NLS eReader Zoomax braille display.
It supports both USB and Bluetooth automatic detection.

Description of user facing changes:

With this driver the user can use directly the NLS eReader Zoomax display without the need to manually install it as an addon.

Description of developer facing changes:

Description of development approach:

The driver is similar with the existing braille display drivers for NVDA.

Testing strategy:

Known issues with pull request:

Code Review Checklist:

Documentation:
- Change log entry
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
Testing:
- Unit tests
- System (end to end) tests
- Manual testing
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
API is compatible with existing add-ons.
Security precautions taken.

@coderabbitai summary

LeonarddeR · 2025-06-16T09:41:02Z

@florin-trutiu Make sure to fill in the pull request template by editing pull request description. There's also something wrong with the changes file, resulting into a huge amount of unrelated changes.

florin-trutiu · 2025-06-16T09:48:01Z

@florin-trutiu Make sure to fill in the pull request template by editing pull request description. There's also something wrong with the changes file, resulting into a huge amount of unrelated changes.

@LeonarddeR
Hi, I'm sorry, please help me, I do not know how to proceed.
I already have a pull request #17509 in which I filled the template.
The problem was that I was requested a few more changes which I only completed now (a few months later) and there it said I was a lot of commits behind.
Now in the old pull request I have no changes, and all my changes and discussions appear here.

AppVeyorBot · 2025-06-16T11:01:21Z

FAIL: Translation comments check. Translation comments missing or unexpectedly included. See build log for more information.
PASS: License check.
PASS: Unit tests.
PASS: System tests (tags: installer NVDA).
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/nwk9978jipsfer35/artifacts/output/nvda_snapshot_pr18260-36844,cfd67c51.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 2.3,
INSTALL_END 1.1,
BUILD_START 0.0,
BUILD_END 26.7,
TESTSETUP_START 0.0,
TESTSETUP_END 0.4,
TEST_START 0.0,
TEST_END 19.5,
FINISH_END 0.1

See test results for failed build of commit cfd67c5126

…oomaxDriver

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

seanbudd · 2025-06-23T08:05:38Z

@SaschaCowley - could we consider this for 2025.2?

LeonarddeR

I like this driver overall but have some concerns about the init logic

Co-authored-by: Leonard de Ruijter <3049216+LeonarddeR@users.noreply.github.com>

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Qchristensen

Looks good, will be a welcome addition for those with Zoomax NLS eReaders.

LeonarddeR

Excellent. Note, the changelog is still scrambled, but I guess that will be fixed before merge.

AppVeyorBot · 2025-06-25T00:06:00Z

PASS: Translation comments check.
PASS: License check.
PASS: Unit tests.
FAIL: System tests (tags: installer NVDA). See test results for more information.
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/fawt6h9072akko2u/artifacts/output/nvda_snapshot_pr18260-36957,b64ac3fa.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 1.5,
INSTALL_END 0.9,
BUILD_START 0.0,
BUILD_END 20.0,
TESTSETUP_START 0.0,
TESTSETUP_END 0.4,
TEST_START 0.0,
TEST_END 20.7,
FINISH_END 0.2

See test results for failed build of commit b64ac3fa10

seanbudd · 2025-06-25T01:38:35Z

Please try doing this again:

Please reset the changes files.

git checkout origin/master -- user_docs/en/changes.md

Then add * Support for the NLS eReader Zoomax braille display has been added. (#15863, @florin-trutiu) under new features

florin-trutiu · 2025-06-25T07:10:22Z

Then add * Support for the NLS eReader Zoomax braille display has been added. (#15863, @florin-trutiu) under new features

@seanbudd
Calling git checkout origin/master -- user_docs/en/changes.md on the fork I have did not bring the latest changes.md file from the nvaccess master repo.
I tried now to copy it manually from the nvaccess repo to my fork.
I hope it worked.

seanbudd · 2025-06-25T07:16:02Z

Hi @florin-trutiu I think that's because you've created your branch off of master, which makes it tricky to fix this easily. Can you please move this branch somewhere else and I can fix it up? i.e. git checkout -b nlsEreader git push?

florin-trutiu · 2025-06-25T07:28:54Z

@seanbudd
Thank you for helping me.
I did the new branch:
https://github.com/florin-trutiu/NLSeReaderZoomaxDriver/tree/nlsEreader

What should I do next ?

Closes #15863 Copy of #18260 Summary of the issue: This is the NVDA driver for the NLS eReader Zoomax braille display. It supports both USB and Bluetooth automatic detection. Description of user facing changes: With this driver the user can use directly the NLS eReader Zoomax display without the need to manually install it as an addon. Description of developer facing changes: Description of development approach: The driver is similar with the existing braille display drivers for NVDA.

seanbudd · 2025-06-25T07:58:59Z

Closed in favour of #18332

florin-trutiu and others added 9 commits June 16, 2025 12:02

Added the NLS eReader Zoomax braille driver

c29cdb5

Edited the user guide.

67c21fb

Pre-commit auto-fix

af98d24

Pre-commit auto-fix

7af14fc

Edited the user guide again.

61e13dc

Added an entry for the NLS eReader Zoomax display in the user guide.

f1de557

Added an entry in the changes.md file.

286952a

Made the requested changes.

2f85762

More changes to the driver.

7d50941

florin-trutiu requested review from a team as code owners June 16, 2025 09:25

florin-trutiu requested review from Qchristensen and seanbudd June 16, 2025 09:25

Pre-commit auto-fix

ebda4ac

florin-trutiu added 2 commits June 16, 2025 16:56

Added back the # Translators: Names of braille displays. entry.

e1d4602

Merge branch 'master' of https://github.com/florin-trutiu/NLSeReaderZ…

7f6e5e9

…oomaxDriver

seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Jun 16, 2025

seanbudd reviewed Jun 17, 2025

View reviewed changes

seanbudd requested a review from SaschaCowley June 17, 2025 04:04

florin-trutiu and others added 7 commits June 17, 2025 12:42

Update user_docs/en/userGuide.md

3924923

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Update source/brailleDisplayDrivers/nlseReaderZoomax.py

1d716d2

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Update source/brailleDisplayDrivers/nlseReaderZoomax.py

0911ee0

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Update source/brailleDisplayDrivers/nlseReaderZoomax.py

6821438

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Update source/brailleDisplayDrivers/nlseReaderZoomax.py

8040219

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Update source/brailleDisplayDrivers/nlseReaderZoomax.py

51506c1

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Small changes, mostly type hints.

94499b5

seanbudd approved these changes Jun 23, 2025

View reviewed changes

Comment thread source/brailleDisplayDrivers/nlseReaderZoomax.py Outdated

seanbudd added this to the 2025.2 milestone Jun 23, 2025

LeonarddeR suggested changes Jun 23, 2025

View reviewed changes

florin-trutiu and others added 6 commits June 23, 2025 14:14

Update source/brailleDisplayDrivers/nlseReaderZoomax.py

41f4320

Co-authored-by: Leonard de Ruijter <3049216+LeonarddeR@users.noreply.github.com>

Update source/brailleDisplayDrivers/nlseReaderZoomax.py

9fda37e

Co-authored-by: Leonard de Ruijter <3049216+LeonarddeR@users.noreply.github.com>

Update source/brailleDisplayDrivers/nlseReaderZoomax.py

0d8046a

Co-authored-by: Leonard de Ruijter <3049216+LeonarddeR@users.noreply.github.com>

Update source/brailleDisplayDrivers/nlseReaderZoomax.py

bf50173

Co-authored-by: Leonard de Ruijter <3049216+LeonarddeR@users.noreply.github.com>

Update source/brailleDisplayDrivers/nlseReaderZoomax.py

429fbd9

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

More improvements

9df43a7

seanbudd requested a review from LeonarddeR June 24, 2025 06:20

Qchristensen approved these changes Jun 24, 2025

View reviewed changes

LeonarddeR approved these changes Jun 24, 2025

View reviewed changes

seanbudd and others added 2 commits June 25, 2025 09:19

Merge branch 'master' into master

99c565a

Pre-commit auto-fix

b210ad7

florin-trutiu added 2 commits June 25, 2025 09:57

Added entry in changes.md.

2071d6f

Added entry in changes.md

fcb5fa9

seanbudd mentioned this pull request Jun 25, 2025

NLS eReader Zoomax braille driver #18331

Closed

5 tasks

seanbudd closed this Jun 25, 2025

seanbudd mentioned this pull request Jun 25, 2025

NLS eReader Zoomax braille driver #18332

Merged

5 tasks

Uh oh!

Conversation

florin-trutiu commented Jun 16, 2025 • edited by seanbudd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link to issue number:

Summary of the issue:

Description of user facing changes:

Description of developer facing changes:

Description of development approach:

Testing strategy:

Known issues with pull request:

Code Review Checklist:

Uh oh!

LeonarddeR commented Jun 16, 2025

Uh oh!

florin-trutiu commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AppVeyorBot commented Jun 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seanbudd commented Jun 23, 2025

Uh oh!

LeonarddeR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Qchristensen left a comment

Choose a reason for hiding this comment

Uh oh!

LeonarddeR left a comment

Choose a reason for hiding this comment

Uh oh!

AppVeyorBot commented Jun 25, 2025

Uh oh!

seanbudd commented Jun 25, 2025

Uh oh!

florin-trutiu commented Jun 25, 2025

Uh oh!

seanbudd commented Jun 25, 2025

Uh oh!

florin-trutiu commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seanbudd commented Jun 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

florin-trutiu commented Jun 16, 2025 •

edited by seanbudd

Loading

florin-trutiu commented Jun 16, 2025 •

edited

Loading

florin-trutiu commented Jun 25, 2025 •

edited

Loading