NLS eReader Zoomax braille driver#18332
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Add support for the NLS eReader Zoomax braille display by providing a new driver implementation and updating documentation.
- Introduce
nlseReaderZoomax.pywith USB and Bluetooth detection and communication protocol handling - Update user guide and change log to list Zoomax as a supported device and include key mappings
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| user_docs/en/userGuide.md | List Zoomax in supported displays and add key chart |
| user_docs/en/changes.md | Add changelog entry for Zoomax support |
| source/brailleDisplayDrivers/nlseReaderZoomax.py | New driver with connection, send/receive, and gestures |
Comments suppressed due to low confidence (2)
user_docs/en/userGuide.md:4513
- This entry appears to be incorrect—replace "* NLS eReader HumanWare" with "* NLS eReader Zoomax" to accurately reflect the Zoomax device.
* NLS eReader HumanWare
source/brailleDisplayDrivers/nlseReaderZoomax.py:84
- [nitpick] There are no unit or integration tests for this new driver; consider adding tests for connection logic and key event handling to ensure future maintainability.
class BrailleDisplayDriver(braille.BrailleDisplayDriver):
| if command == DeviceCommand.DISPLAY_DATA: | ||
| self.numCells = ord(arg) | ||
| elif command in COMMAND_RESPONSE_INFO: | ||
| arg = int.from_bytes(reversed(arg)) |
There was a problem hiding this comment.
Calling int.from_bytes on reversed(arg) without specifying byteorder will fail; use something like int.from_bytes(arg[::-1], 'big') to convert correctly.
Suggested change
| arg = int.from_bytes(reversed(arg)) | |
| arg = int.from_bytes(arg[::-1], 'big') |
This was referenced Jun 25, 2025
Contributor
|
@seanbudd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15863
Copy of #18260
Summary of the issue:
This is the NVDA driver for the NLS eReader Zoomax braille display.
It supports both USB and Bluetooth automatic detection.
Description of user facing changes:
With this driver the user can use directly the NLS eReader Zoomax display without the need to manually install it as an addon.
Description of developer facing changes:
Description of development approach:
The driver is similar with the existing braille display drivers for NVDA.
Testing strategy:
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary