Conversation
SaschaCowley
approved these changes
Jun 16, 2025
seanbudd
added a commit
that referenced
this pull request
Jun 16, 2025
seanbudd
added a commit
that referenced
this pull request
Jul 15, 2025
Closes #18269 Summary of the issue: On the old translation system, pofile's syntax was checked before merging to NVDA. The new system doesn't have this, leading to issues like #18252 Description of user facing changes: Translators will receive warnings / errors with NVDA.po when uploading and downloading translations Description of developer facing changes: Add a pre-commit hook which checks the syntax of pofiles. This will protect commits when pulling translations from crowdin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18250
Summary of the issue:
There was syntax error in the korean translations, which cause the add-on store to fail to open
Description of user facing changes:
Add-on store now opens correctly when NVDA uses korean localisations
Description of developer facing changes:
None
Description of development approach:
Fix string
Testing strategy:
Tested opening the add-on store using korean localisations
Known issues with pull request:
We should be validating these files on commit to NVDA - see also #17289
Code Review Checklist:
@coderabbitai summary