-
-
Notifications
You must be signed in to change notification settings - Fork 767
Validate modified gestures files #17289
Copy link
Copy link
Open
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developerscomponent/i18nexisting localisations or internationalisationexisting localisations or internationalisationcomponent/unit-testingfeature/input-gesturesp3https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Description
Metadata
Metadata
Assignees
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developerscomponent/i18nexisting localisations or internationalisationexisting localisations or internationalisationcomponent/unit-testingfeature/input-gesturesp3https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Is your feature request related to a problem? Please describe.
The German gestures file in NVDA 2024.3 contains syntax errors, that stop it being parsed, and thus stop users who use NVDA in German users from using German keybindings. This only seems to have come to light after a user noticed it in 2024.3.1.
Describe the solution you'd like
Implement a test that attempts to parse gestures files. This could be as simple as attempting to load the ini file with the same settings used by NVDA when loading gestures files, but could also potentially involve attempting to parse the specified gestures to ensure that they are valid.
Describe alternatives you've considered
Continue to rely on translators to not submit invalid files. This places non-English language users at a significant disadvantage, as errors with other languages are much more likely to make it to stable releases.
Additional context
The erroneous lines have been removed from the gestures file included in 2024.4.
We should consider validating other files, such as
symbols.dic,characterDescriptions.dic, andnvda.po.