Remove deprecated config options#18102
Merged
Merged
Conversation
Contributor
|
In any case, something should be done regarding |
Collaborator
|
We can still deprecate it in 2025.1, can't we? |
Member
Author
|
We can still deprecate it, yes. @seanbudd what do you think? Should we remove |
Member
|
@SaschaCowley - I think we need to remove it, as |
…, and comment out call to linking method
seanbudd
reviewed
May 19, 2025
seanbudd
approved these changes
May 19, 2025
LeonarddeR
reviewed
May 19, 2025
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
May 19, 2025
Follow-up to #18102 Summary of the issue: When fixing the `GlobalCommands.script_reportCLDR" method, I forgot that you can't just mutate lists in the config, or configobj doesn't know they've changed, so the changes will not be persisted to disc. Description of user facing changes The toggle CLDR script will now be persisted across sessions. Description of development approach Make a copy of config.conf["speech"]["symbolDictionaries"], mutate it, then save it back. Initially tried just mutating it and then setting it to itself, but this did not work. Presumably there is some check for identity somewhere, and since all empty lists are identicle, __setitem__ was not called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #18066
Summary of the issue:
Some deprecated config keys are still included in the config spec.
Description of user facing changes
None.
Description of developer facing changes
The
config.conf["documentFormatting"]["reportFontAttributes"]definition has been removed from the config spec, and the code linking it and["fontAttributeReporting"]has been removed.Description of development approach
Removed the linking code and the line in the config spec.
Testing strategy:
Unit tests.
Known issues with pull request:
`config.conf["speech"]["includeCLDR"] would ideally also be removed, however the deprecation of this key was not documented, so I am unsure whether to remove it.
Code Review Checklist:
@coderabbitai summary