Fix the toggle report CLDR script"#18126
Merged
Merged
Conversation
5 tasks
LeonarddeR
approved these changes
May 19, 2025
seanbudd
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow-up to #18102
Summary of the issue:
When fixing the `GlobalCommands.script_reportCLDR" method, I forgot that you can't just mutate lists in the config, or configobj doesn't know they've changed, so the changes will not be persisted to disc.
Description of user facing changes
The toggle CLDR script will now be persisted across sessions.
Description of development approach
Make a copy of
config.conf["speech"]["symbolDictionaries"], mutate it, then save it back.Initially tried just mutating it and then setting it to itself, but this did not work. Presumably there is some check for identity somewhere, and since all empty lists are identicle,
__setitem__was not called.Testing strategy:
Known issues with pull request:
None known.
Code Review Checklist:
@coderabbitai summary