Skip to content

Fix the toggle report CLDR script"#18126

Merged
seanbudd merged 1 commit into
betafrom
fixRemoveDeprecatedConfig
May 19, 2025
Merged

Fix the toggle report CLDR script"#18126
seanbudd merged 1 commit into
betafrom
fixRemoveDeprecatedConfig

Conversation

@SaschaCowley

Copy link
Copy Markdown
Member

Link to issue number:

Follow-up to #18102

Summary of the issue:

When fixing the `GlobalCommands.script_reportCLDR" method, I forgot that you can't just mutate lists in the config, or configobj doesn't know they've changed, so the changes will not be persisted to disc.

Description of user facing changes

The toggle CLDR script will now be persisted across sessions.

Description of development approach

Make a copy of config.conf["speech"]["symbolDictionaries"], mutate it, then save it back.
Initially tried just mutating it and then setting it to itself, but this did not work. Presumably there is some check for identity somewhere, and since all empty lists are identicle, __setitem__ was not called.

Testing strategy:

  1. Assign a gesture to the script
  2. Read some text with emojis. Observe the result.
  3. Use the gesture.
  4. Read some text with emojis. Observe the result is different to that in 2.
  5. Save the config. Reload the config.
  6. Read some text with emojis. Observe the result is the same as 4.
  7. Repeat steps 3-6.

Known issues with pull request:

None known.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley requested a review from a team as a code owner May 19, 2025 07:18
@SaschaCowley SaschaCowley added this to the 2025.1 milestone May 19, 2025
@seanbudd seanbudd merged commit 9c4d4f8 into beta May 19, 2025
5 checks passed
@seanbudd seanbudd deleted the fixRemoveDeprecatedConfig branch May 19, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants