Skip to content

Add crowdin upload to GH actions#18035

Merged
SaschaCowley merged 1 commit intomasterfrom
ghCrowdin
May 2, 2025
Merged

Add crowdin upload to GH actions#18035
SaschaCowley merged 1 commit intomasterfrom
ghCrowdin

Conversation

@seanbudd
Copy link
Copy Markdown
Member

@seanbudd seanbudd commented May 1, 2025

Link to issue number:

Part of #17878

Summary of the issue:

Crowdin upload is missing from GitHub actions, which needs to be added to have full parity to AppVeyor

Description of user facing changes

None

Description of development approach

Copy logic from AppVeyor

Testing strategy:

Unfortunately we need to test this on production when we merge master to beta

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@seanbudd seanbudd requested a review from a team as a code owner May 1, 2025 03:05
@seanbudd seanbudd requested a review from SaschaCowley May 1, 2025 03:05
@SaschaCowley SaschaCowley merged commit 206dcb9 into master May 2, 2025
14 checks passed
@SaschaCowley SaschaCowley deleted the ghCrowdin branch May 2, 2025 04:32
@github-actions github-actions bot added this to the 2025.2 milestone May 2, 2025
seanbudd pushed a commit that referenced this pull request Jun 26, 2025
follow up #18035
Summary of the issue:

The cache does not contain nvda.pot, additional steps are needed to download the file
Description of user facing changes:

Fix the above issue
Description of developer facing changes:

Fix the above issue
Description of development approach:

Add steps to download nvda.pot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants