Improve crowdinUpload jobs for GH Actions workflows#18333
Merged
seanbudd merged 1 commit intonvaccess:masterfrom Jun 26, 2025
Merged
Improve crowdinUpload jobs for GH Actions workflows#18333seanbudd merged 1 commit intonvaccess:masterfrom
seanbudd merged 1 commit intonvaccess:masterfrom
Conversation
Member
|
@wmhn1872265132 - you linked a pull requests rather than an issue in your "fixes" comment. Could you rather say this is a "follow up" to that. There's changes to this code happening in #18330 - can you remove the stuff around env/var changes? Otherwise this looks good to go, thanks for catching this |
d5e4071 to
26fc742
Compare
Contributor
Author
|
@seanbudd Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
follow up #18035
Summary of the issue:
The cache does not contain nvda.pot, additional steps are needed to download the file
Description of user facing changes:
Fix the above issue
Description of developer facing changes:
Fix the above issue
Description of development approach:
Add steps to download nvda.pot
Testing strategy:
Unfortunately we need to test this on production when we merge master to beta
Known issues with pull request:
Not know
Code Review Checklist:
@coderabbitai summary