Add a WS_EX_TOOLWINDOW window style to the highlight window.#17711
Merged
Conversation
seanbudd
approved these changes
Feb 20, 2025
5 tasks
gexgd0419
pushed a commit
to gexgd0419/nvda
that referenced
this pull request
Feb 22, 2025
Fixed: nvaccess#17696 Summary of the issue: When the highlighter is enabled, the NVDA Highlighter Window icon is fixed on the taskbar after restarting Explorer. Description of user facing changes The NVDA Highlighter Window icon is no longer fixed in the taskbar after restarting Explorer. Description of development approach Add a WS_EX_TOOLWINDOW window style to the highlight window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixed: #17696
Summary of the issue:
When the highlighter is enabled, the NVDA Highlighter Window icon is fixed on the taskbar after restarting Explorer.
Description of user facing changes
The NVDA Highlighter Window icon is no longer fixed in the taskbar after restarting Explorer.
Description of development approach
Add a
WS_EX_TOOLWINDOWwindow style to the highlight window.Testing strategy:
To test manually:
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary