Remove audio logo from NVDA launcher#17507
Conversation
Can we improve this? Is it possible to use a shorter sound? In order to let users know that the update has started, rather than being stuck for some reason. |
Unfortunately |
|
Can we take a look at Inno Setup? |
|
@dpy013 - we do not intend to add back a launcher sound or migrate from NSIS for the time being. I'd encourage dropping the concern |
# Conflicts: # user_docs/en/changes.md
…uide (#17519) Summary of the issue: In #17507, the audio logo played while the NVDA launcher is loading has been removed. However, the quick start guide still makes a reference to the music playing before a temporary copy of NVDA loads. Description of user facing changes The quick start guide no longer includes misleading information. Instead, it has been replaced with a note that it may take a few seconds for the temporary copy to load. --------- Co-authored-by: Sean Budd <seanbudd123@gmail.com>
|
Hello! I agree that this is not a good alternative. In any case with a shorter start sound. Anyway on my computer the installer of the last 2026.1 Beta 1 and the last alphas also take time to load the temporary copy. My computer is a ASUS X541UAK with an Intel (R) Core (TM) I3-6006U cpu @ 2.00GHZ, 1992 MHz, 2 main processors, 4 logical processors. |
Link to issue number:
Closes #14068
Closes #15110
Summary of the issue:
The NVDA launcher currently plays an audio logo when launched.
This creates a number of problems:
Description of user facing changes
The NVDA launcher is now silent until the temporary copy of NVDA it includes is started.
Description of development approach
Removed all code related to playing the audio logo from
launcher/launcher.nsis.Testing strategy:
Built the launcher and ran it from explorer.
Also ran NVDA from source patched to check for updates, and swapped the downloaded launcher for the one without the sound logo.
Known issues with pull request:
There is now an appreciable period of silence between NVDA quitting to perform an update, and the temporary NVDA speaking to read out the update progress.
Code Review Checklist:
@coderabbitai summary