Removed a reference to the launcher audio logo from the quick start guide#17519
Merged
Conversation
seanbudd
reviewed
Dec 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
In #17507, the audio logo played while the NVDA launcher is loading has been removed. However, the quick start guide still makes a reference to the music playing before a temporary copy of NVDA loads.
Description of user facing changes
The quick start guide no longer includes misleading information. Instead, it has been replaced with a note that it may take a few seconds for the temporary copy to load.
Description of development approach
Replaced the information in the user guide.
Testing strategy:
Check the user guide, ensuring there are no references to the launcher music.
Known issues with pull request:
None known.
Code Review Checklist:
@coderabbitai summary