Respect 'Say all on page load' in PowerPoint slide shows#17488
Conversation
|
Is this potentially intended behaviour? i.e. do users generally want say-all when in present mode for powerpoint? it seems more intuitive |
|
I personally prefer no say all in Power Point slide show mode. Note that say all on page load is the default behavior for NVDA, so people who have that on will still have the old behavior. People who want to have say all in browse mode disabled and enabled in Power Point can do so with a configuration profile. |
|
The fact is that there is a need to have say all on new slide disabled for some people such as @LeonarddeR. So this possibility should be implemented in some way. I prefer from far using "Enable browse mode on page load" value for this, rather than creating a new option. It makes sense to me and I feel the result is expected. Slides are considered as page here, but it seems consistent. Actually, to be quite consistent, I'd say that this option should apply to any browse mode content for which "Enable browse mode on page load" applies, that is the uses cases where the browse mode is the main use case; that includes browsers, PDF reader, Outlook e-mail reading and PowerPoint slideshow. On the contrary, the option should not apply for applications where browse mode is only a tool, but not the main use case; that includes Outlook e-mail writing, Word documents, Excel sheets. As noted by @LeonarddeR, "Enable browse mode on page load" is checked by default, so the behavior will not change for the majority of people. And I imagine that the few people who uncheck this option, also expect say all not to start on PowerPoint slides. To make things extra-clear, maybe the documentation of "Automatic Say All on page load" option should be enhanced with examples of situations/documents where this option applies. |
|
Well to summarize, I support 100% including PowerPoint slides in this option. |
seanbudd
left a comment
There was a problem hiding this comment.
Thanks @LeonarddeR and @CyrilleB79 - makes sense
Follow up of #17488 Summary of the issue: Since #17488, entering a slide show in Power point no longer activates say all when that browse mode option is disabled. However, I intended this to also apply to cases where you'd move from one slide to another, which didn't work. Description of user facing changes NO say all when moving from slide to slide in a slide show and the browse mode option is disabled. Description of development approach Expanded the reportSlide method.
Link to issue number:
None
Summary of the issue:
When Browse mode setting "say all on page load" is disabled, NVDA yet starts say all in a slide show.
Description of user facing changes
NVDA no longer automatically starts say all when starting a PowerPoint slide show and "say all on page load" is disabled.
Description of development approach
Check the config setting.
Testing strategy:
Tested that NVDA no longer starts say all when the option is disabled.
Known issues with pull request:
None known
Code Review Checklist:
@coderabbitai summary