Fix Powerpoint say all on new slide#17498
Merged
Merged
Conversation
seanbudd
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow up of #17488
Summary of the issue:
Since #17488, entering a slide show in Power point no longer activates say all when that browse mode option is disabled. However, I intended this to also apply to cases where you'd move from one slide to another, which didn't work.
Description of user facing changes
NO say all when moving from slide to slide in a slide show and the browse mode option is disabled.
Description of development approach
Expanded the reportSlide method.
Testing strategy:
Tested moving from slide to slide with say all on page load enabled and disabled.
Known issues with pull request:
None known.
Code Review Checklist:
@coderabbitai summary