Complete support of bk:space and bk:space+dots gestures for Seika Notetaker#16828
Conversation
WalkthroughThe Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
See test results for failed build of commit 90e03e4c35 |
5372a9c to
54eb9d7
Compare
See test results for failed build of commit cad52d5ce2 |
|
Hi @md_curran, Sorry, I am not familiar to the lint check. I think I got nothing from the AppVeyorBot report. If I must do anymore before merge, please tell me. The PR is important for many Taiwanese users, because it determines whether BrlIMEHelper works for Seika Notetaker. BrlIMEHelper is an add-on converting braille input into IME emulation, which can be thought of as another implementation of braille input handler. Seika Notetaker, called BPDA (亮點) by Taiwanese, is a majority of braille displays that students can borrow from the government organization. Thus, students with Seika Notetakers are eager for fix of the driver to facilitate their learning. Thanks. |
See: https://ci.appveyor.com/project/NVAccess/nvda/builds/50160022#L5371 |
|
I would encourage running |
if brailleDots:
if key in (1, 2, 3):
1. bk:space+dots. key is cleared.
else:
2. bk:dots. key may be not 0.
if key:
if key in (1, 2):
3. bk:space. If bk:space+dots is triggered, the case must not be true.
else:
4. br(seikantk):XXX, otherwise.
54eb9d7 to
219d5bf
Compare
|
Can you please add a changelog entry detailing this bug fix? |
|
Hi, I have uploaded the new changelog entry. However, the md file now uses different symbol |
| ### Bug Fixes | ||
|
|
||
| * NVDA once again relies on UIA events for caret movement in XAML and WPF text controls, rather than only on manual querying of the caret position. (#16817, @LeonarddeR) | ||
| * The Seika Notetaker driver now correctly generates braille input for braille space and space with dots gestures. (#16642, @school510587) |
There was a problem hiding this comment.
Is this correct? I think there's a typo
| * The Seika Notetaker driver now correctly generates braille input for braille space and space with dots gestures. (#16642, @school510587) | |
| * The Seika Notetaker driver now correctly generates braille input for space and backspace with dots gestures. (#16642, @school510587) |
|
@school510587 good catch with the markdown issue. Do you mind updating that file in a separate PR? |
|
Hi @seanbudd, I think I should clearly specify which gestures are influenced, and there are actually 5: space, backspace, space with dots, backspace with dots, and space with backspace with dots. So I use "space, backspace and space/backspace with dots". Please tell me if there is any better representation, thanks. |
OK. Please see #16860. |
Fixes issue 3 of #16828 . Summary of the issue: The br(seikantk):XXX IDs of bk:space and bk:space+dots are incorrect. Although it has few influence to UX, it may bring trouble to add-on developers. Description of user facing changes There must be one option displayed when adding a new gesture in Input gestures dialog is about Seika Notetaker. Without this PR, the option is always backspace+dX, e.g. backspace+d1+d3+d4+d5. Now, backspace+d1+d3+d4+d5, d1+d3+d4+d5+space, and backspace+d1+d3+d4+d5+space are displayed correctly according to the actual space key(s) pressed by the user. Description of development approach Type of space parameter of class InputGesture becomes int. It may be 1(backspace), 2(space), or 3(both). The correct key name is obtained from _getKeyNames.
Link to issue number:
Closes #16642.
Summary of the issue:
Two drivers are mentioned in the issue, eurobraille and seikantk. The user can change an option of the former to solve the issue. However, there is no feasible approach for the user to solve the issue for the latter manually, which is the aim of the PR.
Description of user facing changes
The user can perceive the changes by three ways.
Description of development approach
4 cases of input gestures are explicitly specified in seikantk.py, and the algorithm description is available in the commit log.
Testing strategy:
The most simple way to test is to run input help. Be sure that your working braille display is Seika Notetaker.
Case 1:
Case 2:
It is OK to test the change through the input translation table.
Known issues with pull request:
There are two notable issues currently.
Code Review Checklist:
Summary by CodeRabbit
keysanddotsinto a single gesture, improving the user experience.spacekey mappings are no longer included erroneously, preventing conflicts.