Revert "Remove redundant braille.BrailleHandler.update executions"#16499
Closed
LeonarddeR wants to merge 1 commit into
Closed
Revert "Remove redundant braille.BrailleHandler.update executions"#16499LeonarddeR wants to merge 1 commit into
LeonarddeR wants to merge 1 commit into
Conversation
…access#16463)" This reverts commit 29f4c5c.
Collaborator
Author
|
@burmancomp While I"m convinced that you will certainly try to fix this, I think it is better to revert this first and then try to fix it, afterwards rather than providing a fixup pr for #16463. |
Contributor
|
I am quite optimistic that I would have fix for this problem. If I open new pr, can you then test if it works for you? |
Collaborator
Author
|
Sure, go ahead if you wish. |
Member
|
Closing in favour of #16501 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts PR
Reverts #16463
Issues fixed
None
Issues reopened
Reopens #16456
Reason for revert
The reverted pr causes unexpected side effects for message buffers while the scope of the issue it fixes is a bit unclear.
Can this PR be reimplemented? If so, what is required for the next attempt
Braille updates should still properly dismiss message buffers.