HP Secure Browser support (#16377): Detect brchrome and flag it as not supporting IAccessible2#16392
Merged
Merged
Conversation
…it as not supporting IAccessible2. Summary of the issue: Users have to explicitly configure in NVDA advanced options to "use UIA for Edge and other chromium based browsers", for NVDA to work with HP Secure Browser. Description of user facing changes: Users won't have to explicitly configure UIA for all chromium-based browsers when they want to use HP Secure Browser Description of development approach: Detect browser with a process name of "brchrome" which represents HP Secure Browser and flag it as not supporting IAccecssible2. In this scenario, UIA will be used by default for HP SB.
seanbudd
approved these changes
Apr 16, 2024
tomaszw
pushed a commit
to tomaszw/nvda-hp
that referenced
this pull request
Apr 17, 2024
…access#16395 Summary of the issue: Changelog entries are missing for nvaccess#16392 nvaccess#16393 nvaccess#16394 nvaccess#16395 Description of user facing changes: Added Changelog entries Description of development approach: N/A
5 tasks
tomaszw
pushed a commit
to tomaszw/nvda-hp
that referenced
this pull request
Apr 17, 2024
…access#16395 Summary of the issue: Changelog entries are missing for nvaccess#16392 nvaccess#16393 nvaccess#16394 nvaccess#16395 Description of user facing changes: Added Changelog entries Description of development approach: N/A
tomaszw
pushed a commit
to tomaszw/nvda-hp
that referenced
this pull request
Apr 17, 2024
…access#16395 Summary of the issue: Changelog entries are missing for nvaccess#16392 nvaccess#16393 nvaccess#16394 nvaccess#16395 Description of user facing changes: Added Changelog entries Description of development approach: N/A
seanbudd
added a commit
that referenced
this pull request
Apr 18, 2024
* Changelog entries for #16392 #16393 #16394 #16395 Summary of the issue: Changelog entries are missing for #16392 #16393 #16394 #16395 Description of user facing changes: Added Changelog entries Description of development approach: N/A * Apply suggestions from code review --------- Co-authored-by: Tomasz Wroblewski <tomasz.wroblewski@hp.com> Co-authored-by: Sean Budd <seanbudd123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#16377
Summary of the issue:
HP Secure Browser is part of HP Wolf Security package. It is a chromium-based web browser where individual websites are isolated in separate virtual machines. To support screen readers, windows UIA trees are remoted between the virtual machines and the host. IAccessible2 interface is not remoted, hence HP Secure Browser is a rare case of chromium-browser which supports UIA but not IAccessible2.
Users have to explicitly configure in NVDA advanced options to "use UIA for Edge and other chromium based browsers", for NVDA to work with HP Secure Browser.
Description of user facing changes
Users won't have to explicitly configure UIA for all chromium-based browsers when they want to use HP Secure Browser
Description of development approach
Detect browser with a process name of "brchrome" which represents HP Secure Browser and flag it as not supporting IAccecssible2. In this scenario, UIA will be used by default for HP SB.
Testing strategy:
Manual testing
Known issues with pull request:
N/A
Code Review Checklist: