Skip to content

Changelog entries for #16392 #16393 #16394 #16395#16410

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
tomaszw:hp-secure-browser-changelog
Apr 18, 2024
Merged

Changelog entries for #16392 #16393 #16394 #16395#16410
seanbudd merged 2 commits into
nvaccess:masterfrom
tomaszw:hp-secure-browser-changelog

Conversation

@tomaszw

@tomaszw tomaszw commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

Link to issue number:

N/A

Summary of the issue:

Changelog entries are missing for #16392 #16393 #16394 #16395

Description of user facing changes

Added Changelog entries

Description of development approach

N/A

Testing strategy:

N/A

Known issues with pull request:

N/A

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@tomaszw tomaszw marked this pull request as ready for review April 17, 2024 07:17
@tomaszw tomaszw requested a review from a team as a code owner April 17, 2024 07:17
@tomaszw tomaszw requested a review from seanbudd April 17, 2024 07:17
Comment thread user_docs/en/changes.t2t Outdated
Comment thread user_docs/en/changes.t2t Outdated
@tomaszw tomaszw force-pushed the hp-secure-browser-changelog branch from 49f8422 to 4db7f3f Compare April 17, 2024 14:07
Comment thread user_docs/en/changes.t2t Outdated
@tomaszw tomaszw force-pushed the hp-secure-browser-changelog branch from da1071c to e17a045 Compare April 17, 2024 16:54
…access#16395

Summary of the issue:
Changelog entries are missing for nvaccess#16392 nvaccess#16393 nvaccess#16394 nvaccess#16395

Description of user facing changes:
Added Changelog entries

Description of development approach:
N/A
@CyrilleB79

Copy link
Copy Markdown
Contributor

Last remark, you may optionally add the reference to your GitHub's name along with the GitHub numbers mentioned in the change log.

It's not mandatory, but IMO, it help knowing who has worked on various parts of the code, what is sometimes useful. Just my opinion though.

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomaszw

Comment thread user_docs/en/changes.t2t Outdated
Comment thread user_docs/en/changes.t2t Outdated
@seanbudd seanbudd merged commit 3b06122 into nvaccess:master Apr 18, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants