Skip to content

Fix NVDA not reading in Geekbench 6#16268

Merged
seanbudd merged 6 commits into
nvaccess:masterfrom
mzanm:geekbenchfix
Mar 7, 2024
Merged

Fix NVDA not reading in Geekbench 6#16268
seanbudd merged 6 commits into
nvaccess:masterfrom
mzanm:geekbenchfix

Conversation

@mzanm

@mzanm mzanm commented Mar 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #16251

Summary of the issue:

NVDA does not read in Geekbench 6 and plays an error sound.

Description of user facing changes

Geekbench can be used with NVDA.

Description of development approach

See diff and linked issue.

Testing strategy:

Tested that Geekbench can be used with NVDA and no errors appear in the log.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@mzanm mzanm requested a review from a team as a code owner March 6, 2024 15:13
@mzanm mzanm requested a review from SaschaCowley March 6, 2024 15:13
@OzancanKaratas OzancanKaratas requested review from SaschaCowley and seanbudd and removed request for SaschaCowley March 6, 2024 15:21
CyrilleB79
CyrilleB79 reviewed Mar 6, 2024
View reviewed changes
Comment thread source/UIAHandler/__init__.py Outdated
@CyrilleB79

CyrilleB79 commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

An item in the bugfix section of the change log would also be desirable. Thanks.

@AppVeyorBot

AppVeyorBot commented Mar 6, 2024

Copy link
Copy Markdown

See test results for failed build of commit cd7869a541

@seanbudd seanbudd marked this pull request as draft March 7, 2024 02:23
@AppVeyorBot

AppVeyorBot commented Mar 7, 2024

Copy link
Copy Markdown

See test results for failed build of commit acb1ad0648

@mzanm mzanm marked this pull request as ready for review March 7, 2024 05:58
seanbudd
seanbudd approved these changes Mar 7, 2024
View reviewed changes
Comment thread source/UIAHandler/__init__.py Outdated
Comment thread user_docs/en/changes.t2t
seanbudd
seanbudd reviewed Mar 7, 2024
View reviewed changes
Comment thread source/UIAHandler/__init__.py Outdated
@seanbudd seanbudd merged commit 12a5b76 into nvaccess:master Mar 7, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Mar 7, 2024
Adriani90 pushed a commit to Adriani90/nvda that referenced this pull request Mar 13, 2024
@mzanm @Adriani90
Fix NVDA not reading in Geekbench 6 (nvaccess#16268)
c438142 
Fixes nvaccess#16251

Summary of the issue:
NVDA does not read in Geekbench 6 and plays an error sound.

Description of user facing changes
Geekbench can be used with NVDA.

Description of development approach
See diff and linked issue.
@mzanm mzanm deleted the geekbenchfix branch May 12, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

@SaschaCowley SaschaCowley Awaiting requested review from SaschaCowley

+1 more reviewer

@CyrilleB79 CyrilleB79 CyrilleB79 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2024.2

Development

Successfully merging this pull request may close these issues.

NVDA does not read in the Geekbench 6 utility

5 participants

@mzanm @CyrilleB79 @AppVeyorBot @seanbudd @nvaccessAuto