Fix status reporting of speech modes checkboxes#16006
Conversation
lukaszgo1
left a comment
There was a problem hiding this comment.
Please explicitly mention in your testing steps that you have verified that when the 'talk' mode is unchecked warning is shown, and answering both affirmative and negative behaves as expected.
Co-authored-by: Łukasz Golonka <lukasz.golonka@mailbox.org>
Done. |
|
@ABuffEr, you have branched from beta branch and you have indicated that you want to have this fix merged into beta. That's OK since this fix an unreleased bug. However this PR still targets the master branch. To target beta branch, you need to edit the title of this PR. Below the editable field allowing you to change the title of the PR, you will find combo-boxes. One of them is the target branch and you can replace master by beta, and then validate. HTH. |
|
Hi @CyrilleB79, thanks a lot for your tip! Done, despite some unresponsive behaviors (at least with Firefox). |
Fixes nvaccess#16005. Summary of the issue: When enabling/disabling checkboxes in the speech modes list, under voice settings, the new status was not reported by speech or Braille. Description of user facing changes Now user hears "enabled" or "disabled", and gets his Braille display refreshed. Description of development approach PR nvaccess#15960 has introduced a new handler of EVT_CHECKLISTBOX event for speechModesList. But this latter is an nvdaControls.CustomCheckListBox, that already defines an handler for that event, to fix specifically this accessibility issue of wx. So I simply put evt.Skip() at the beginning of new handler, to propagate event to custom control handler.
Link to issue number:
Fixes #16005.
Summary of the issue:
When enabling/disabling checkboxes in the speech modes list, under voice settings, the new status was not reported by speech or Braille.
Description of user facing changes
Now user hears "enabled" or "disabled", and gets his Braille display refreshed.
Description of development approach
PR #15960 has introduced a new handler of EVT_CHECKLISTBOX event for speechModesList.
But this latter is an nvdaControls.CustomCheckListBox, that already defines an handler for that event, to fix specifically this accessibility issue of wx.
So I simply put evt.Skip() at the beginning of new handler, to propagate event to custom control handler.
Testing strategy:
Manual, with steps of #16005.
I verified also that, unchecking "talk" mode, the warning dialog (introduced by PR #15960) is still shown, and choosing "yes" or "no" the behavior remains coherent (checkbox disabled answering "yes" to continue, still enabled answering "no").
Known issues with pull request:
None.
Code Review Checklist: