Detach disabling "talk" speech mode warning dialog#15960
Conversation
|
This PR does not require a change log |
|
Given discussion in #15894 especially #15894 (comment) this was quite unpopular with users. If you believe that these arguments are not valid please explain why. Otherwise I suggest to close this. |
No, this will not trigger warning dialog boxes frequently. |
See test results for failed build of commit 426cb62a01 |
|
I believe we should be aiming for consistency here, i.e. all warnings appear at the same time that is when closing the dialog. Lets wait for more feedback on this PR. |
|
On the contrary, I believe that we should issue warnings / error as soon as possible. It was not possible for the "select at least two items" use case, since a standard way to select two items may be transitioning through a state where only one item is selected. On the contrary, as soon as a user deselects "Talk":
In conclusion, I am in favor of the changes in this PR. |
|
if we don't want users to deselect talk I think we should remove it from the user accessible options entirely and forcibly include it internally. I think we initially included it in the settings as an earlier goal was to ensure either "on-demand" or "talk" was included, not just "talk". |
From the discussion on #15806 and #15873 the goal was to allow users to deselect 'talk', since this may be potentially useful for magnification users, but make sure this is not done by mistake. Frankly given how much time has been spent discussing if it should be de-selectable or not I'd suggest not to spent more time on this i.e. merge this PR, as it improves the behavior. IMO the UX can be reconsidered if one of the following happens:
|
|
Thanks for the reminder and explainer @lukaszgo1 |
Fixes #16005. Summary of the issue: When enabling/disabling checkboxes in the speech modes list, under voice settings, the new status was not reported by speech or Braille. Description of user facing changes Now user hears "enabled" or "disabled", and gets his Braille display refreshed. Description of development approach PR #15960 has introduced a new handler of EVT_CHECKLISTBOX event for speechModesList. But this latter is an nvdaControls.CustomCheckListBox, that already defines an handler for that event, to fix specifically this accessibility issue of wx. So I simply put evt.Skip() at the beginning of new handler, to propagate event to custom control handler.
Related nvaccess#15894 Summary of the issue: Disable the "talk" speech mode warning dialog box can be completely separated for judgment, as the status of this option does not need to be guaranteed when determining the settings Description of user facing changes When "talk" is deselected, a warning dialog box pops up. If "no" is chosen, then "talk" is set back to the selected state Description of development approach Move the "talk" speech mode warning dialog to the method bound to the wx.EVT_CHECKLISTBOX event.
Fixes nvaccess#16005. Summary of the issue: When enabling/disabling checkboxes in the speech modes list, under voice settings, the new status was not reported by speech or Braille. Description of user facing changes Now user hears "enabled" or "disabled", and gets his Braille display refreshed. Description of development approach PR nvaccess#15960 has introduced a new handler of EVT_CHECKLISTBOX event for speechModesList. But this latter is an nvdaControls.CustomCheckListBox, that already defines an handler for that event, to fix specifically this accessibility issue of wx. So I simply put evt.Skip() at the beginning of new handler, to propagate event to custom control handler.
Link to issue number:
Related #15894
Summary of the issue:
Disable the "talk" speech mode warning dialog box can be completely separated for judgment, as the status of this option does not need to be guaranteed when determining the settings
Description of user facing changes
When "talk" is deselected, a warning dialog box pops up. If "no" is chosen, then "talk" is set back to the selected state
Description of development approach
Move the "talk" speech mode warning dialog to the method bound to the
wx.EVT_CHECKLISTBOXevent.Testing strategy:
Known issues with pull request:
Code Review Checklist: