Skip to content

Remove and ignore English nvda.po as it is not needed, yet is provid…#15997

Merged
seanbudd merged 1 commit into
masterfrom
beta
Jan 2, 2024
Merged

Remove and ignore English nvda.po as it is not needed, yet is provid…#15997
seanbudd merged 1 commit into
masterfrom
beta

Conversation

@seanbudd

@seanbudd seanbudd commented Jan 2, 2024

Copy link
Copy Markdown
Member

…ed by Crowdin. (#15989)

Mentioned in pr #15968

Summary of the issue:
When exporting translated po files from Crowdin, English is also included. this is not needed and just takes up space in the repository.

Description of user facing changes
None

Description of development approach
Remove the accidentally committed English nvda.po
Add English nvda.po to .gitignore so that it is not committed again.

Link to issue number:

Summary of the issue:

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

…d by Crowdin. (#15989)

Mentioned in pr #15968

Summary of the issue:
When exporting translated po files from Crowdin, English is also included. this is not needed and just takes up space in the repository.

Description of user facing changes
None

Description of development approach
Remove the accidentally committed English nvda.po
Add English nvda.po to .gitignore so that it is not committed again.
@seanbudd seanbudd requested a review from a team as a code owner January 2, 2024 01:26
@seanbudd seanbudd requested a review from gerald-hartig January 2, 2024 01:26
@seanbudd seanbudd merged commit 5bb365d into master Jan 2, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants