Skip to content

Update translations#15968

Merged
seanbudd merged 1 commit into
betafrom
translations
Dec 26, 2023
Merged

Update translations#15968
seanbudd merged 1 commit into
betafrom
translations

Conversation

@michaelDCurran

Copy link
Copy Markdown
Member

No description provided.

@michaelDCurran michaelDCurran marked this pull request as ready for review December 26, 2023 22:33
@michaelDCurran michaelDCurran requested a review from a team as a code owner December 26, 2023 22:33
@michaelDCurran michaelDCurran requested review from seanbudd and removed request for a team December 26, 2023 22:33
@seanbudd seanbudd merged commit eedafa9 into beta Dec 26, 2023
@seanbudd seanbudd deleted the translations branch December 26, 2023 22:59
@seanbudd seanbudd added this to the 2024.1 milestone Dec 26, 2023
@lukaszgo1

Copy link
Copy Markdown
Contributor

@michaelDCurran This PR introduces source/locale/en/LC_MESSAGES/nvda.po. I'm flagging this as a concern, because even though I cannot tell if it causes any real issues, usually the base language has no translation file.

@michaelDCurran

michaelDCurran commented Dec 29, 2023 via email

Copy link
Copy Markdown
Member Author

@lukaszgo1

Copy link
Copy Markdown
Contributor

Do we understand why it got created by Crowdin in the first place?

seanbudd pushed a commit that referenced this pull request Jan 1, 2024
…d by Crowdin. (#15989)

Mentioned in pr #15968

Summary of the issue:
When exporting translated po files from Crowdin, English is also included. this is not needed and just takes up space in the repository.

Description of user facing changes
None

Description of development approach
Remove the accidentally committed English nvda.po
Add English nvda.po to .gitignore so that it is not committed again.
Adriani90 pushed a commit to Adriani90/nvda that referenced this pull request Mar 13, 2024
Adriani90 pushed a commit to Adriani90/nvda that referenced this pull request Mar 13, 2024
…d by Crowdin. (nvaccess#15989)

Mentioned in pr nvaccess#15968

Summary of the issue:
When exporting translated po files from Crowdin, English is also included. this is not needed and just takes up space in the repository.

Description of user facing changes
None

Description of development approach
Remove the accidentally committed English nvda.po
Add English nvda.po to .gitignore so that it is not committed again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants