Conversation
seanbudd
approved these changes
Jan 1, 2024
5 tasks
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
…d by Crowdin. (nvaccess#15989) Mentioned in pr nvaccess#15968 Summary of the issue: When exporting translated po files from Crowdin, English is also included. this is not needed and just takes up space in the repository. Description of user facing changes None Description of development approach Remove the accidentally committed English nvda.po Add English nvda.po to .gitignore so that it is not committed again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Mentioned in pr #15968
Summary of the issue:
When exporting translated po files from Crowdin, English is also included. this is not needed and just takes up space in the repository.
Description of user facing changes
None
Description of development approach
.gitignoreso that it is not committed again.Testing strategy:
File is not known to NVDA.
Known issues with pull request:
None known.
Code Review Checklist: