Windows 11 emoji panel: replace regular editable text with NVDAObjects.UIA.XamlEditableText#15837
Merged
seanbudd merged 1 commit intoNov 27, 2023
Conversation
…s.UIA.XamlEditableText when removin editable field support from emoji panel. Re nvaccess#15836. Regression introduced with nvaccess#14888: Windows 11 emoji panel items are not annonced when pressing arrow keys as XAML editable text overlay class is used to mark emoji search field. Therefore, remove the newly introduced XAML editable text class from overlay class chooser.
seanbudd
approved these changes
Nov 27, 2023
Member
|
is this worth adding a change log entry for? |
Member
|
ah i see this was a regression |
Contributor
Author
|
Hi, nope as this is a regression with #14888 and how UIA classes were reorganized in the process. Thanks.
|
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Nov 28, 2023
…t and actual editable text auto select detection behavior. Re #15836. (#15848) Addresses initial flaw found in #15837 Summary of the issue: Turns out both XAML editable text and editable text auto-select detection behavior must be removed to let emoji panel items be announced when using arrow keys. Description of user facing changes Windows 11 emoji panel items can be reported when using arrow keys. Description of development approach Both XAML editable text and editable text with auto-select detection behavior must be removed when handling Windows 11 emoji panel text field to allow arrow keys to work when reviewing emoji panel entries. I'm sure there is a more elegant solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15836
Summary of the issue:
Windows 11 emoji panel items are not annonced when using arrow keys to navigate the emoji panel.
Description of user facing changes
Emoji panel items are once again announced when using the arrow keys to navigate Windows 11 emoji panel.
Description of development approach
In modern keyboard/emoji panel app modue, replace regular editable text with NVDAObjects.UIA.XamlEditableText when detecting and removing edit field commands form emoji search field.
Testing strategy:
Manual test: make sure emoji panel items are announced when using arrow keys after opening Windows 11 emoji panel.
Known issues with pull request:
None
Code Review Checklist: