Skip to content

Windows 11 emoji panel: remove both XAML editable text and editable text selection detection behavior#15848

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
josephsl:i15836part2
Nov 28, 2023
Merged

Windows 11 emoji panel: remove both XAML editable text and editable text selection detection behavior#15848
seanbudd merged 1 commit into
nvaccess:masterfrom
josephsl:i15836part2

Conversation

@josephsl

Copy link
Copy Markdown
Contributor

Hi,

Follow-up to #15837:

Link to issue number:

Addresses initial flaw found in #15837

Summary of the issue:

Turns out both XAML editable text and editable text auto-select detection behavior must be removed to let emoji panel items be announced when using arrow keys.

Description of user facing changes

Windows 11 emoji panel items can be reported when using arrow keys.

Description of development approach

Both XAML editable text and editable text with auto-select detection behavior must be removed when handling Windows 11 emoji panel text field to allow arrow keys to work when reviewing emoji panel entries. I'm sure there is a more elegant solution.

Testing strategy:

Manual testing: make sure emoji panel items are announced when using arrow keys.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

…t and actual editable text auto select detection behavior. Re nvaccess#15836.

It is not enough to remove XAML editable text support when Windows 11 emoji panel opens - remove editable text with selection detection behavior as well.
@josephsl josephsl requested a review from a team as a code owner November 28, 2023 05:30
@seanbudd seanbudd merged commit 8052b68 into nvaccess:master Nov 28, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Nov 28, 2023
@josephsl josephsl deleted the i15836part2 branch December 7, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants