Conversation
michaelDCurran
approved these changes
Sep 28, 2023
c74c10d to
da27960
Compare
See test results for failed build of commit 9230fb0c5f |
Contributor
|
This PR resolves a number of "found unreachable objects" errors in Chrome and should be merged as soon as practical. |
seanbudd
pushed a commit
that referenced
this pull request
Oct 18, 2023
Discussion in #15299 Unblocks PR #15546 Summary of the issue: The version of Flake8 we're using is extremely old. While it worked well up to now, it does not support some newer syntactic construct in recent versions of Python (in particular walrus operator). Unfortunately we cannot update to the latest release, since it does not support flake8-tabs, nor linting a diff (the latter can be achieved using external tools). Description of user facing changes None Description of development approach Flake8 is updated to the version 4.0.1. This is the last version which supports flake8-tabs, and it also recognizes various newer language constructs in Python, by the simple fact that it was released almost 2.5 years after the version we're using currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Clean up of #15544
Summary of the issue:
from __future__ import annotationscan be removedDescription of user facing changes
Should be none
Description of development approach
Straight forward code deprecation or implementation of noted comments
Testing strategy:
Alpha testing needed.
Basic manual smoke test performed
Known issues with pull request:
None
Code Review Checklist: