Remove enum patches on Python 3.11#15531
Merged
seanbudd merged 1 commit intonvaccess:py311from Sep 26, 2023
Merged
Conversation
…sent in Python 3.11+. Partially reverts nvaccess#12617.
Member
|
The py311 branch is not ready yet, however, these fixes are not in conflict with expected changes |
seanbudd
pushed a commit
that referenced
this pull request
Sep 27, 2023
…sent in Python 3.11+. (#15531) Partially reverts #12617. Summary of the issue: #12617 added a patched __new__ to work around a GC cycle in Python 3.7. However, on Python 3.11 and 3.12, this is no longer present. Description of how this pull request fixes the issue: Remove the patched method. Testing strategy: Tested that On Python 3.7, the cyclic ref is present when the patched __new__ is removed. On Python 3.11, no unreachable object error is reported in IA2 documents. On Python 3.12, no unreachable object error is reported in IA2 documents.
seanbudd
added a commit
that referenced
this pull request
Oct 18, 2023
Clean up of #15544 Summary of the issue: from __future__ import annotations can be removed gettext now supports pgettext and npgettext, NVDA's implementations can be abandoned enum patches can be removed Remove enum patches on Python 3.11 #15531 Description of user facing changes Should be none Description of development approach Straight forward code deprecation or implementation of noted comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Partially reverts #12617.
Summary of the issue:
#12617 added a patched
__new__to work around a GC cycle in Python 3.7. However, on Python 3.11 and 3.12, this is no longer present.Description of how this pull request fixes the issue:
Remove the patched method.
Testing strategy:
Tested that
__new__is removed.Known issues with pull request:
None known
Change log entry:
None needed
Code Review Checklist: