Update fast_diff_match_patch to 2.0.1#15514
Merged
seanbudd merged 2 commits intonvaccess:masterfrom Sep 26, 2023
Merged
Conversation
See test results for failed build of commit dd19a463ee |
Member
|
I think we should always note dependency upgrades either in |
ce6f6d3 to
3970451
Compare
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Oct 12, 2023
Fix-up of #15513 #15514 . Description of how this pull request fixes the issue: Add @codeofdusk attributions for Python 3.11 upgrade
michaelDCurran
added a commit
that referenced
this pull request
Feb 12, 2024
This reverts commit 69a16cc.
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Feb 13, 2024
Fixes #16027 Reverts #15514 This reverts commit 69a16cc. Summary of the issue: PR #15514 upgraded diff_match_patch from 1.0.2 to fast_diff_match_patch 2.0.1. However, the newer version cannot handle particular unicode characters such as 🍰. The diff_match_patch process dies, NvDA can no longer report text changes, and NvDA hangs on exit. Description of user facing changes Printing unicode characters such as 🍰 in a terminal withn using diff_match_patch for speaking changes no longer causes NvDA to no longer report text changes and lock up on exit. Description of development approach Downgrade back to diff_match_patch 1.0.2.
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
Fixes nvaccess#16027 Reverts nvaccess#15514 This reverts commit 69a16cc. Summary of the issue: PR nvaccess#15514 upgraded diff_match_patch from 1.0.2 to fast_diff_match_patch 2.0.1. However, the newer version cannot handle particular unicode characters such as 🍰. The diff_match_patch process dies, NvDA can no longer report text changes, and NvDA hangs on exit. Description of user facing changes Printing unicode characters such as 🍰 in a terminal withn using diff_match_patch for speaking changes no longer causes NvDA to no longer report text changes and lock up on exit. Description of development approach Downgrade back to diff_match_patch 1.0.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
The
diff-match-patch-pythonpackage changed its name tofast_diff_match_patch.Description of how this pull request fixes the issue:
Update to the new package name, changing nvda_dmp accordingly.
Testing strategy:
Verified that diffing in consoles works.
Known issues with pull request:
None known
Change log entry:
None needed
Code Review Checklist: