Skip to content

Add @codeofdusk attributions for Python 3.11 upgrade#15609

Merged
seanbudd merged 1 commit intonvaccess:py311-minfrom
codeofdusk:fix-attributions-2024-2
Oct 12, 2023
Merged

Add @codeofdusk attributions for Python 3.11 upgrade#15609
seanbudd merged 1 commit intonvaccess:py311-minfrom
codeofdusk:fix-attributions-2024-2

Conversation

@codeofdusk
Copy link
Copy Markdown
Contributor

@codeofdusk codeofdusk commented Oct 12, 2023 •
edited by seanbudd
Loading

Link to issue number:

Fix-up of #15513 #15514 .

Description of how this pull request fixes the issue:

Add @codeofdusk attributions for Python 3.11 upgrade

Testing strategy:

N/A

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@codeofdusk codeofdusk requested a review from a team as a code owner October 12, 2023 02:38
@codeofdusk codeofdusk requested review from seanbudd and removed request for a team October 12, 2023 02:38
@seanbudd seanbudd closed this Oct 12, 2023
@seanbudd
Copy link
Copy Markdown
Member

seanbudd commented Oct 12, 2023

Please do not accredit authors on their behalf. It is up to the author to opt into accreditation

@codeofdusk
Copy link
Copy Markdown
Contributor Author

codeofdusk commented Oct 12, 2023

This PR includes contributions by me. How do I opt into accreditation?

@seanbudd
Copy link
Copy Markdown
Member

seanbudd commented Oct 12, 2023

Apologies, the PR description was misleading:

Many community contributions in 2024.1 are missing attributions.

@seanbudd seanbudd reopened this Oct 12, 2023
@seanbudd seanbudd changed the title Add attributions for 2024.1 (2 of 2) Add @codeofdusk attributions for Python 3.11 upgrade Oct 12, 2023
@seanbudd seanbudd merged commit afa0d92 into nvaccess:py311-min Oct 12, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd Awaiting requested review from seanbudd seanbudd was automatically assigned from nvaccess/developers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2024.1

Development

Successfully merging this pull request may close these issues.

3 participants

@codeofdusk @seanbudd @nvaccessAuto