Skip to content

Don't hide installed add-ons in available add-ons list#15380

Merged
seanbudd merged 3 commits into
betafrom
includeInstalledInAvailable
Sep 7, 2023
Merged

Don't hide installed add-ons in available add-ons list#15380
seanbudd merged 3 commits into
betafrom
includeInstalledInAvailable

Conversation

@seanbudd

@seanbudd seanbudd commented Sep 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15374

Summary of the issue:

At present, if you use the available add-ons category, add-ons already installed are not shown in the list.
This is causing confusion, where users expect add-ons to listed in the available add-ons tab, regardless if installed.

The main use case is the following user story:
I am a user who has installed VeryCoolAddon. I want to recommend a friend to use it. I check in the add-on store via the "Add-on catalog" tab (formerly "Available add-ons" tab) that the add-on is still in the store and its version. Note: add-ons may be removed from the store for various reasons, so you cannot be certain if the add-on is still available in the add-on store if it is already installed.

Description of user facing changes

add-ons which are already installed will no longer be hidden in the available add-ons list

Description of development approach

Include all the same statuses in the installed add-ons tab in the available add-ons tab. (#15374)

Testing strategy:

Manual testing

Known issues with pull request:

None

Change log entries:

Changes

  • Add-on Store: Installed add-ons will now be listed in the Available Add-ons tab, if they are still available in the store.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner September 6, 2023 05:40
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team September 6, 2023 05:40
@seanbudd seanbudd added this to the 2023.3 milestone Sep 6, 2023
@LeonarddeR

LeonarddeR commented Sep 6, 2023

Copy link
Copy Markdown
Collaborator

I would honestly only include add-ons that are available in the add-ons store on the available tab. In other words, the available list should just contain all add-ons available in the add-ons store, regardless whether installed or not.
I think yet including installed add-ons no longer available in the store on the available tab causes more confusion than it solves.
That said, I wonder whether we could either have a status for add-ons that were installed from the store but no longer available, or mark these add-ons as external.

@seanbudd

seanbudd commented Sep 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

@LeonarddeR - that is the current implementation, I'll update the PR description to be clearer.

For reference, the function _createListItemVMs provides the filtering that you may be concerned about based on the list tab selected

@seanbudd seanbudd changed the title Include installed add-ons in available add-ons list Don't hide installed add-ons in available add-ons list Sep 6, 2023
@LeonarddeR

LeonarddeR commented Sep 6, 2023

Copy link
Copy Markdown
Collaborator

Thanks. So just to make sure, installed add-ons either from an external source or no longer available in the store won't be listed? That's perfect!

@seanbudd

seanbudd commented Sep 6, 2023

Copy link
Copy Markdown
Member Author

Yes exactly

@CyrilleB79

CyrilleB79 commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

Users have no knowledge of "hidden" add-ons. Thus for the change log, I'd rather see something like:
Add-ons installed from the Add-on Store will now appear too in the available add-ons list

@seanbudd

seanbudd commented Sep 6, 2023

Copy link
Copy Markdown
Member Author

@CyrilleB79 - I don't think that description is accurate for this change. I also disagree that the notion of something being hidden is confusing.

@seanbudd

seanbudd commented Sep 6, 2023

Copy link
Copy Markdown
Member Author

@Qchristensen - what do you think about the change log entry here? would you be able to suggest an alternative changelog entry for this?

For reference:
The current behaviour is that if an add-on is currently installed, and no updates are available, it is filtered so that is not shown in the available add-ons list. This PR ensures that this filtering no longer happens.

@seanbudd

seanbudd commented Sep 6, 2023

Copy link
Copy Markdown
Member Author

Add-ons installed from the Add-on Store will now appear too in the available add-ons list

installed add-ons either from an external source

I just thought I'd mention that if an add-on has been installed from an external source but is available in the add-on store it will also be shown in the available add-ons tab

@CyrilleB79

CyrilleB79 commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

@CyrilleB79 - I don't think that description is accurate for this change. I also disagree that the notion of something being hidden is confusing.

@seanbudd, you write:

The current behaviour is that if an add-on is currently installed, and no updates are available, it is filtered so that is not shown in the available add-ons list.

That's true from the point of view of a dev knowing the code. But in the User Guide or in the GUI, there is no mention at all of the list being populated with all add-ons in the store and then filtered, nor add-ons hidden in this list; so for the end user installed add-ons are just not in the list. Hence my suggestion to say that this list now shows something more, rather than saying that it hides or filters something less.

Anyway, it's just a change log item; so if I can't make myself make understood, just ignore my comment.

@CyrilleB79

CyrilleB79 commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

Testing this PR:

  • When an add-on is installed, in the available list the status is "Enabled" or "Disabled". It would be better to have "Installed". Or if you prefer, "Installed, enabled" and "Installed, disabled", but I do not feel this precision is necessary.
  • In the available add-on list, you can migrate to add-on store, install an add-on, enable or disable installed add-ons, but not uninstall installed add-ons. IMO uninstalling from available list should be added for coherence with the opposite possible actions (install or migrate)
  • Any feedback to the suggestion to rename "Available add-ons" tab to "Add-on catalog"? No problem if you do not accept it, but just wanted to clarify it.

@XLTechie

XLTechie commented Sep 6, 2023 via email

Copy link
Copy Markdown
Collaborator

@XLTechie

XLTechie commented Sep 6, 2023 via email

Copy link
Copy Markdown
Collaborator

@seanbudd

seanbudd commented Sep 7, 2023

Copy link
Copy Markdown
Member Author

thanks @XLTechie , that's a bit more accurate

@seanbudd

seanbudd commented Sep 7, 2023

Copy link
Copy Markdown
Member Author

When an add-on is installed, in the available list the status is "Enabled" or "Disabled". It would be better to have "Installed". Or if you prefer, "Installed, enabled" and "Installed, disabled", but I do not feel this precision is necessary.

I understand that the status texts aren't ideal, however we believe it may be more confusing/misleading if the statuses are different depending on the add-on list tab you are viewing,

In the available add-on list, you can migrate to add-on store, install an add-on, enable or disable installed add-ons, but not uninstall installed add-ons. IMO uninstalling from available list should be added for coherence with the opposite possible actions (install or migrate)

Making actions available depending on the add-on list being viewed is currently intended behaviour.

Any feedback to the suggestion to rename "Available add-ons" tab to "Add-on catalog"? No problem if you do not accept it, but just wanted to clarify it.

I don't see a clear reason to rename this, but if there is popular support for this change we can consider it in future.

michaelDCurran
michaelDCurran previously approved these changes Sep 7, 2023
View reviewed changes
@seanbudd seanbudd merged commit c40903c into beta Sep 7, 2023
@seanbudd seanbudd deleted the includeInstalledInAvailable branch September 7, 2023 04:16
@XLTechie

XLTechie commented Sep 7, 2023 via email

Copy link
Copy Markdown
Collaborator

@CyrilleB79 CyrilleB79 mentioned this pull request Sep 8, 2023
Closed
@seanbudd seanbudd mentioned this pull request Sep 11, 2023
Merged
6 tasks
seanbudd added a commit that referenced this pull request Sep 11, 2023
@seanbudd
Include installed incompatible add-ons in the available add-ons list (#…
b0d56e2 
…15421)

Link to issue number:
Fixup of #15380
Fixes #15405

Summary of the issue:
Installed incompatible add-ons are not show in the available add-ons list

Description of user facing changes
Incompatible installed add-ons are no longer hidden from the available add-ons tab

Description of development approach
Remove the filter for installed add-ons when generating the incompatible add-ons list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelDCurran michaelDCurran michaelDCurran left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023.3

Development

Successfully merging this pull request may close these issues.

5 participants

@seanbudd @LeonarddeR @CyrilleB79 @XLTechie @michaelDCurran