Reintroduce Improve shortcut key reporting (#14900)#15373
Merged
Conversation
…ccess#15237)" This reverts commit e15fe8a.
7f8a256 to
4228022
Compare
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Oct 9, 2023
…5572) Closes #15566 Fix-up of #14900 / #15373. Summary of the issue: In #14900 / #15373., spelling mode was used (CharacterModeCommand) no matter the state of the "Use spelling functionality" option. The use spelling functionality exists because some old SAPI synth do not support spelling mode correctly. For them, this option needs to be honored. Description of user facing changes Use spelling functionality option will now be honored when reporting shortcuts. Description of development approach See logic in the code. If use spelling functionality option is disabled, the key is just reported as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10807
Reintroduce the changes of PR #14900 that were reverted in #15237.
Summary of the issue:
See #14900 for the initial issue.
#14900 had to be reverted since it caused any speech sequence containing a character mode command to spell the whole speech sequence with Code Factory driver. Although the issue is in the driver and not NVDA, it has been decided to wait for an API-breaking release to issue this fix so that Code Factory synth users be not impacted by this bug.
Description of user facing changes
Same as #14900, that is:
Shortcut key reporting will be improved in some cases. This applies to on-demand reporting (shift+numpad2) as well as when "Report Object Shortcut Keys" option is checked in Object presentation settings.
The cases where it should be improved are:
Braille reporting should remain unchanged.
Description of development approach
Revert #15237 to reintroduce the changes in #14900 and remove change log modifications.
Testing strategy:
Re-execute the tests in #14900.
Known issues with pull request:
In addition to limitations listed in #14900:
This PR will trigger again Code Factory synthesizer's bug. The bug has already been reported to Code Factory; so they will have the opportunity to fix it for 2024.1 release.
Change log entries:
Bug fixes
Reporting of object shortcut keys has been improved. (#10807)Code Review Checklist: